Feature/space packet seq flags - #18
Open
shan-zh-26 wants to merge 190 commits into
Open
Conversation
This reverts commit f48314f.
… NAK processed logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
cherry-picks the CCSDS sequence-flags support (NASA PR nasa#5445) onto monarch — replaces the hardcoded 0x3 unsegmented flags with context.get_sequenceFlags().
Rationale
Aquila components need to use seq flags to support segmented packets (continuation / first / last / unsegmented).
Testing/Review Recommendations
Aquila emulator is able to simulate a large file transfer with seq flags specified, and FSW side should be able to interpret the incoming segmented packets using these flags.
Future Work
AI Usage (see policy)
Use AI to resolve the conflict in unit test.