Skip to content

Add Hyundai Grandeur Diesel 2019 support - #320

Merged
FrogAi merged 3 commits into
FrogAi:MAKE-PRS-HEREfrom
atawi44:MAKE-PRS-HERE
Oct 14, 2026
Merged

FrogAi merged 3 commits into
FrogAi:MAKE-PRS-HEREfrom
atawi44:MAKE-PRS-HERE

Conversation

@atawi44

@atawi44 atawi44 commented Sep 14, 2026

Copy link
Copy Markdown

No description provided.

@github-actions

Copy link
Copy Markdown

Thank you for your PR! If you're not already in the FrogPilot Discord, feel free to join and let me know you've opened a PR!

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@FrogAi

FrogAi commented Sep 30, 2026

Copy link
Copy Markdown
Owner

I pushed a commit to your PR that lines the port up with the other IG cars. The platform is now "HYUNDAI_AZERA_DIESEL_6TH_GEN", the docs name is "Hyundai Azera Diesel 2019" so the year parses, and it's in the lane-line HUD list with the other IG cars. I also dropped "MANDO_RADAR" since the route you drove on your openpilot fork ran without it. If your car does output radar points on "0x500" on "bus 1", let me know and we can add it back. Could you pull the latest version of your branch and do a drive? Engaging, steering, pressing the gas and brake, and checking the lane lines on the cluster would cover it. If you had the car picked manually in "Car Model", you'll need to pick "Hyundai Azera Diesel 2019" again since the platform name changed.

@atawi44

atawi44 commented Oct 8, 2026

Copy link
Copy Markdown
Author

I pushed a commit to your PR that lines the port up with the other IG cars. The platform is now "HYUNDAI_AZERA_DIESEL_6TH_GEN", the docs name is "Hyundai Azera Diesel 2019" so the year parses, and it's in the lane-line HUD list with the other IG cars. I also dropped "MANDO_RADAR" since the route you drove on your openpilot fork ran without it. If your car does output radar points on "0x500" on "bus 1", let me know and we can add it back. Could you pull the latest version of your branch and do a drive? Engaging, steering, pressing the gas and brake, and checking the lane lines on the cluster would cover it. If you had the car picked manually in "Car Model", you'll need to pick "Hyundai Azera Diesel 2019" again since the platform name changed.

I tried testing the latest version as requested: FrogPilot 0.10.3, branch MAKE-PRS-HERE, commit de96f95. Unfortunately, openpilot crashes on startup before I can test the car.

The traceback points to selfdrive/selfdrived/selfdrived.py, line 172. It fails while trying to block the development branch:
AttributeError: module 'openpilot.system.sentry' has no attribute 'capture_message'
photo_2026-10-09_00-18-41
photo_2026-10-09_00-18-51

I’ve attached photos of the crash and traceback. I wasn’t able to test engagement, steering, gas/brake, or the lane lines. Could you let me know how I can test the port once this startup issue is fixed?

@FrogAi

FrogAi commented Oct 8, 2026

Copy link
Copy Markdown
Owner

That crash comes from the branch name. "MAKE-PRS-HERE" is blocked from running on a car, and that snapshot is missing "sentry.capture_message", so it crashes instead of showing the block message. Even without the crash, that branch name would force the car to "MOCK". Could you create a new branch on your fork from "MAKE-PRS-HERE" with any other name, for example "azera-diesel", and install it with "installer.comma.ai/atawi44/azera-diesel"? It's the same commit, so the port will be identical, and the same drive will cover it.

@atawi44

atawi44 commented Oct 11, 2026 •

Copy link
Copy Markdown
Author

That crash comes from the branch name. "MAKE-PRS-HERE" is blocked from running on a car, and that snapshot is missing "sentry.capture_message", so it crashes instead of showing the block message. Even without the crash, that branch name would force the car to "MOCK". Could you create a new branch on your fork from "MAKE-PRS-HERE" with any other name, for example "azera-diesel", and install it with "installer.comma.ai/atawi44/azera-diesel"? It's the same commit, so the port will be identical, and the same drive will cover it.

I verified the logs in Cabana for route 591e02541f012642|00000003--06b5e7a288.

Mando radar tracks are clearly active on bus 1, transmitting continuously across the entire range from 0x500 up to 0x53F with dynamic payloads.

Please re-enable MANDO_RADAR for this platform. Everything else during the drive (steering, gas/brake disengage, cluster HUD lane lines) worked flawlessly.

image

@FrogAi

FrogAi commented Oct 14, 2026

Copy link
Copy Markdown
Owner

I re-enabled "MANDO_RADAR" in a new commit. I checked your route too. "0x500" through "0x53F" are on "bus 1", the tracks decode with the Mando DBC, and the radar interface turns them into points. Thanks for testing!

@FrogAi
FrogAi merged commit 766ed33 into FrogAi:MAKE-PRS-HERE Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants