Repository navigation
Re-export internal items instead of connecting internal -> import (MAPL3 connection rules) - #447
Merged
Merged
Conversation
…PL3 connection rules)
|
This PR is being prevented from merging because you have not added one of our required labels: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled, github_actions. Please add one so that the PR can be merged. |
bena-nasa
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MAPL3 (GEOS-ESM/MAPL#5502, branch
feature/#5286-graph-phase-5) now validates connections inparse_connections.F90. A simple connection must be EXPORT -> IMPORT; the only other allowed form is a re-export (dst_intent: export). Regression configurations that connected a data component'sinternalitem straight to a sibling's import fail at setServices with:Simple connection needs export -> import, got src_intent=internal dst_intent=importChange
mapl: connections:(src_comp: <self>,src_intent: internal,dst_comp: <self>,dst_intent: export, same name). The items stay understates: internal:.root.yaml,src_intent: internalis removed from the connection, so it is a plain export -> import.Config YAML only. The branch name matches the MAPL PR branch so CircleCI's
mepo checkout-if-existspicks it up.Testing
The changed YAML files parse, and each
root.yamlconnection list is unchanged apart from the removedsrc_intent. I have not built GEOSgcm or run the regression tests locally; CI is the first run.