Skip to content

Re-export internal items instead of connecting internal -> import (MAPL3 connection rules) - #447

Merged
tclune merged 1 commit into
release/MAPL-v3from
feature/#5286-graph-phase-5
Nov 12, 2026
Merged

tclune merged 1 commit into
release/MAPL-v3from
feature/#5286-graph-phase-5

Conversation

@tclune

@tclune tclune commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator

Summary

MAPL3 (GEOS-ESM/MAPL#5502, branch feature/#5286-graph-phase-5) now validates connections in parse_connections.F90. A simple connection must be EXPORT -> IMPORT; the only other allowed form is a re-export (dst_intent: export). Regression configurations that connected a data component's internal item straight to a sibling's import fail at setServices with:

Simple connection needs export -> import, got src_intent=internal dst_intent=import

Change

  • In each data component's config file, every item that is connected is re-exported under mapl: connections: (src_comp: <self>, src_intent: internal, dst_comp: <self>, dst_intent: export, same name). The items stay under states: internal:.
  • In root.yaml, src_intent: internal is removed from the connection, so it is a plain export -> import.
  • Only items that some connection uses are re-exported. Nothing else changed.

Config YAML only. The branch name matches the MAPL PR branch so CircleCI's mepo checkout-if-exists picks it up.

Testing

The changed YAML files parse, and each root.yaml connection list is unchanged apart from the removed src_intent. I have not built GEOSgcm or run the regression tests locally; CI is the first run.

@tclune
tclune requested a review from a team as a code owner November 12, 2026 17:53
@github-actions

Copy link
Copy Markdown

This PR is being prevented from merging because you have not added one of our required labels: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled, github_actions. Please add one so that the PR can be merged.

@tclune
tclune merged commit b10a540 into release/MAPL-v3 Nov 12, 2026
14 of 16 checks passed
@tclune
tclune deleted the feature/#5286-graph-phase-5 branch November 12, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants