Add ordered-float support - #484
Open
saulshanabrook wants to merge 1 commit into
Open
saulshanabrook wants to merge 1 commit into
saulshanabrook wants to merge 1 commit into
Conversation
This PR adds support for the ordered-float library. It treats them like the underlying float value they wrap. It doesn't support NaN's since these are not supported elsewhere in this library.
This was referenced Dec 5, 2025
hombit
pushed a commit
to light-curve/light-curve-feature
that referenced
this pull request
Apr 10, 2026
Replace manual JsonSchema implementations with #[schemars(with = "...")] derive attribute, removing ~80 lines of boilerplate. The json_schema! macro is fully removed. ordered-float uses a git fork until upstream schemars 1.x support lands: - reem/rust-ordered-float#174 - GREsau/schemars#484 Types still using manual impls: SortedArray (ndarray Array1<T> lacks JsonSchema) and Transformed (complex trait bounds).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the ordered-float library. It treats them like the underlying float value they wrap. It doesn't support NaN's since these are not supported elsewhere in this library.