fix(pty): 修复 Docker 数据卷下的终端启动与 resize 回退 - #106
Merged
yxsj245 merged 2 commits intoAug 7, 2026
Merged
Conversation
…inux When data/terminal-control is missing or owned by another user (e.g. root), fall back to ~/.gsm3/terminal-control and $TMPDIR/gsm3-terminal-control-<uid> so Steam install and terminal sessions can still start. Co-authored-by: RainySY <sakuradairong@users.noreply.github.com>
… path Docker and packaged deployments store PTY/Zip-Tools/7z under data/lib, but start.sh runs from server/ so PtyManager only checked server/data/lib. When gsm3_data volume mounts over server/data, built-in binaries are lost. - start.sh: seed server/data/lib from data/lib and recover invalid PTY - package.js: mirror lib assets to server/data/lib and improve linux start.sh - ptyManager/zipToolsManager: add ../data/lib lookup for server cwd - Dockerfile: backup downloaded lib assets to /root/data/lib outside volume Co-authored-by: RainySY <sakuradairong@users.noreply.github.com>
This was referenced Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #104 for Docker and packaged deployments where persistent volumes can hide runtime binaries and root-owned paths can block the PTY resize control channel.
~/.gsm3and a private$TMPDIR/gsm3-terminal-control-<uid>server/data/libfilecommand so valid PTY assets are no longer deleted during container startupScope
Clean branch based on the latest
upstream/main:Verification
cd server && npx tsc --noEmitcd client && npx tsc --noEmitnpm --prefix server run buildnpm --prefix client run buildcd server && npx jest --runInBand— 5 suites / 40 tests passingbash -n start.shgit diff --check upstream/main...HEADgit merge-tree --write-tree upstream/main HEAD— cleanDocker integration verification with a fresh persistent data volume:
33x98to49x146(verified withstty size)/tmp/gsm3-terminal-control-0with mode0700Review result
No blocking code-review findings or merge conflicts were found. Client build only reports the existing chunk-size/dynamic-import warnings unrelated to this change.