Skip to content

IGCL Version Check Update - #681

Closed
markgalvan-intel wants to merge 1 commit into
mainfrom
release/2.6.0
Closed

IGCL Version Check Update#681
markgalvan-intel wants to merge 1 commit into
mainfrom
release/2.6.0

Conversation

@markgalvan-intel

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an IGCL control library compatibility check that blocks IGCL telemetry initialization when mixed/incompatible control library versions are detected across GPUs, and introduces unit tests for the version classification predicates.

Changes:

  • Add IgclControlLibCompatibility helper to detect mixed IGCL control library versions via per-GPU ControlApiPath registry entries and PE file version parsing.
  • Gate IgclTelemetryProvider initialization on the compatibility result (fail fast with TelemetrySubsystemAbsent).
  • Add unit tests validating the version bucket predicates and mismatch detection logic.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
IntelPresentMon/UnitTests/UnitTests.vcxproj.filters Adds the new IGCL compatibility unit test source to project filters.
IntelPresentMon/UnitTests/UnitTests.vcxproj Builds the new IGCL compatibility unit test source.
IntelPresentMon/UnitTests/IgclControlLibCompatibilityTests.cpp Adds predicate-level unit tests for IGCL control library version classification/mismatch logic.
IntelPresentMon/ControlLib/igcl/IgclTelemetryProvider.cpp Blocks IGCL telemetry initialization when compatibility check indicates mismatch/unknown.
IntelPresentMon/ControlLib/igcl/IgclControlLibCompatibility.h Introduces compatibility-check API and ControlLibFileVersion model.
IntelPresentMon/ControlLib/igcl/IgclControlLibCompatibility.cpp Implements registry enumeration + file version parsing + mismatch detection.
IntelPresentMon/ControlLib/ControlLib.vcxproj.filters Adds new compatibility implementation/header into the ControlLib project filters.
IntelPresentMon/ControlLib/ControlLib.vcxproj Adds new compatibility implementation/header to the ControlLib build.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread IntelPresentMon/ControlLib/igcl/IgclControlLibCompatibility.cpp
Comment thread IntelPresentMon/ControlLib/igcl/IgclControlLibCompatibility.h
Comment thread IntelPresentMon/ControlLib/igcl/IgclControlLibCompatibility.cpp Outdated
Comment thread IntelPresentMon/ControlLib/igcl/IgclTelemetryProvider.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants