IGCL Version Check Update - #681
Closed
markgalvan-intel wants to merge 1 commit into
Closed
Conversation
markgalvan-intel
requested review from
planetchili
and
a lite review from Copilot
August 28, 2026 17:48
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an IGCL control library compatibility check that blocks IGCL telemetry initialization when mixed/incompatible control library versions are detected across GPUs, and introduces unit tests for the version classification predicates.
Changes:
- Add
IgclControlLibCompatibilityhelper to detect mixed IGCL control library versions via per-GPUControlApiPathregistry entries and PE file version parsing. - Gate
IgclTelemetryProviderinitialization on the compatibility result (fail fast withTelemetrySubsystemAbsent). - Add unit tests validating the version bucket predicates and mismatch detection logic.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| IntelPresentMon/UnitTests/UnitTests.vcxproj.filters | Adds the new IGCL compatibility unit test source to project filters. |
| IntelPresentMon/UnitTests/UnitTests.vcxproj | Builds the new IGCL compatibility unit test source. |
| IntelPresentMon/UnitTests/IgclControlLibCompatibilityTests.cpp | Adds predicate-level unit tests for IGCL control library version classification/mismatch logic. |
| IntelPresentMon/ControlLib/igcl/IgclTelemetryProvider.cpp | Blocks IGCL telemetry initialization when compatibility check indicates mismatch/unknown. |
| IntelPresentMon/ControlLib/igcl/IgclControlLibCompatibility.h | Introduces compatibility-check API and ControlLibFileVersion model. |
| IntelPresentMon/ControlLib/igcl/IgclControlLibCompatibility.cpp | Implements registry enumeration + file version parsing + mismatch detection. |
| IntelPresentMon/ControlLib/ControlLib.vcxproj.filters | Adds new compatibility implementation/header into the ControlLib project filters. |
| IntelPresentMon/ControlLib/ControlLib.vcxproj | Adds new compatibility implementation/header to the ControlLib build. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
markgalvan-intel
force-pushed
the
release/2.6.0
branch
from
August 28, 2026 18:10
04f14b8 to
e13fce6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.