Mute sync resume no longer races the media replay - #1844
Draft
aleksandar-apostolov wants to merge 1 commit into
Draft
aleksandar-apostolov wants to merge 1 commit into
aleksandar-apostolov wants to merge 1 commit into
Conversation
resumeMuteSync flushed the tracks skipped while the SFU was being torn down, then connectRtc restarted listenToMediaChanges and its collectLatest replay re-signalled the same tracks milliseconds later. The same-track job coalescing cancelled the flush mid-request, logging IOException: Canceled - the symptom the gate was added to remove. The replay already re-signals camera, microphone and screen-share on the only path that reaches the flush, so resume now just re-opens the gate and pendingMuteSyncTracks goes away with it. Closes AND-1549
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
Contributor
SDK Size Comparison 📏
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Fixes AND-1549
Follow-up to #1796.
Implementation
resumeMuteSync()only re-opens themuteSyncEnabledgate. ThelistenToMediaChanges()collectLatestreplay is the single path that re-signals tracks after reconnect.pendingMuteSyncTracksand its bookkeeping insyncMuteStateToSfu(),cleanup()and
cancelActiveWork().post to a torn-down SFU.
Net -41 lines. No public API change.
Testing
./gradlew :stream-video-android-core:testDebugUnitTest— 1270 passed, 0 failed./gradlew :stream-video-android-core:spotlessCheck :stream-video-android-core:apiCheckRtcSessionTest2gainsmute sync resumes without replaying the tracks it skipped—verified it fails when the flush is reinstated.