Skip to content

bootstrap-peers: add pocketlawb with a dialable p2p multiaddr #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
boyroywax wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bootstrap-peers: add pocketlawb with a dialable p2p multiaddr #297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion bootstrap-peers.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"$comment": "Canonical seed list for the Gitlawb network. Merged with GITLAWB_BOOTSTRAP_PEERS at startup. PRs to add public nodes welcome.",
"version": 1,
"updated": "2026-06-30",
"updated": "2026-08-01",
"peers": [
{
"name": "gitlawb",
Expand Down Expand Up @@ -42,6 +42,14 @@
"http_url": "https://rapybus-gitlawb.com",
"p2p_multiaddr": null,
"added": "2026-05-16"
},
{
"name": "pocketlawb",
"operator": "pocketlawb",
"did": "did:key:z6MkiKcvf32z2tcNCGKscxmtszZqpBUrVFa82FTvPnfAhDNF",
"http_url": "https://node.pocketlawb.com",
"p2p_multiaddr": "/dns4/node.pocketlawb.com/udp/7546/quic-v1/p2p/12D3KooWMGuHkbfJ9gTHL7dFozefF3PruxGMvRopE8prPC7eScNH",
"added": "2026-08-01"
Comment on lines +45 to +52

@coderabbitai coderabbitai Bot Aug 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

rg -n -C 12 'fn merge_into_vecs|p2p_multiaddr|p2p_bootstrap|Multiaddr' crates/gitlawb-node/src/bootstrap.rs
rg -n -C 8 'embedded_seed_list_parses_successfully|merge_seeds|pocketlawb' crates/gitlawb-node

Repository: Gitlawb/node

Length of output: 12576

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Inspect the exact new peer entry and determine whether there is any direct regression test for merge_into_vecs with embedded JSON.
python3 - <<'PY'
from pathlib import Path
import re
json_path = Path("bootstrap-peers.json")
bootstrap = Path("crates/gitlawb-node/src/bootstrap.rs")

data = json_path.read_text()
for m in re.finditer(r'\{"name"\s*:\s*"pocketlawb"[\s\S]*?\n\s*\}', data):
    block = m.group(0)
    print("pocketlawb_block:")
    print(block)
    print("contains_p2p_multiaddr=", '"p2p_multiaddr"' in block)

src = bootstrap.read_text()
print("embedded_regression_uses_merge_into_vecs=", "merge_into_vecs" in src[src.find("fn embedded_seed_list_parses_successfully"):])
PY

# Check whether the libp2p crate is available in vendor/tooling without executing repo code.
if command -v cargo >/dev/null 2>&1; then
  cargo --version
  cargo tree --package gitlawb-node --no-dedupe 2>/dev/null | rg 'libp2p|Multiaddr|libp2p-core' | head -50 || true
fi

Repository: Gitlawb/node

Length of output: 142

Validate the new multiaddr through the bootstrap merge path.

merge_into_vecs parses p2p_multiaddr with Multiaddr::from_str before adding it to config.p2p_bootstrap, but embedded_seed_list_parses_successfully only calls parse_seed_list. Add a regression that runs the embedded JSON through merge_into_vecs for the new pocketlawb entry, or add a specific merge test for this address.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@bootstrap-peers.json` around lines 45 - 52, Add a regression test covering
the new pocketlawb p2p_multiaddr through merge_into_vecs, rather than only
parse_seed_list; verify the embedded JSON or specific address is successfully
parsed and added to config.p2p_bootstrap without failure, reusing the existing
bootstrap configuration and test helpers.

}
]
}