Fix regex in partition_gpu to support MIG profiles with + and - suffixes after reboot - #630
Closed
ankitjoju-google wants to merge 1 commit into
Closed
Fix regex in partition_gpu to support MIG profiles with + and - suffixes after reboot#630ankitjoju-google wants to merge 1 commit into
ankitjoju-google wants to merge 1 commit into
Conversation
rawsocket
approved these changes
Aug 11, 2026
ankitjoju-google
force-pushed
the
fix-gpu-partition-regex-g4
branch
from
August 11, 2026 19:16
f81302a to
2436759
Compare
The regex used to parse nvidia-smi mig -lgi output was missing + and - in the character class for profile names, causing parsing to fail for extended MIG profiles (like +gfx or -me) when they already existed. This led to incorrect state detection and failed attempts to recreate active partitions. Added + and - to the character class and added unit tests. BUG=544643611 TAG=agy CONV=00248ed8-608d-4a1c-9326-f43f2e8b5cf4
ankitjoju-google
force-pushed
the
fix-gpu-partition-regex-g4
branch
from
August 11, 2026 20:12
2436759 to
b798cc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regex used to parse
nvidia-smi mig -lgioutput was missing + and - in the character class for profile names, causing parsing to fail for extended MIG profiles (like +gfx or -me) when they already existed (aka after a reboot action). This led to incorrect state detection and failed attempts to recreate active partitions.Added + and - to the character class and added unit tests. All passing