Skip to content

Fix tab shortened path #2321 - #2331

Open
RarityFan437 wants to merge 2 commits into
Guake:masterfrom
RarityFan437:fix-tab-shortened-path-2321
Open

Fix tab shortened path #2321#2331
RarityFan437 wants to merge 2 commits into
Guake:masterfrom
RarityFan437:fix-tab-shortened-path-2321

Conversation

@RarityFan437

Copy link
Copy Markdown

Fixes the layout issue where tab titles failed to update when multiple tabs or splits were active. Replaced direct terminal parent fetching with an iterative tree traversal to correctly find the notebook page index.

Closes #2321

--
RarityFan437

sem-ver: bugfix

@Davidy22 Davidy22 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not strictly a part of your changes, but the comment immediately above the changed block does quite seem like a comment that will become less accurate with this change and probably should be changed too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shortened path in tab label works only for the first tab

2 participants