Skip to content

feat(prefs): add word characters preference - #2332

Open
royy92 wants to merge 1 commit into
Guake:masterfrom
royy92:feat/word-chars-preference
Open

feat(prefs): add word characters preference#2332
royy92 wants to merge 1 commit into
Guake:masterfrom
royy92:feat/word-chars-preference

Conversation

@royy92

@royy92 royy92 commented Jul 17, 2026

Copy link
Copy Markdown

What

Add a new Preferences field for configuring the word-chars setting.

Why

Issue #2304 points out that users currently have no way to configure the word-chars value from the Preferences window.

This also makes the setting easier to manage when using --save-preferences and --load-preferences.

How

  • Add a new word_chars_entry field to guake/data/prefs.glade.
  • Load, update, and reset the word-chars setting in guake/prefs.py.
  • Add a release note in releasenotes/notes/word-chars-preference-9fc892802ca01441.yaml.

Testing

  • Ran make style.
  • Ran make check.
  • Ran make test (30 tests passed).
  • Verified that changing the field updates the word-chars setting.
  • Verified that resetting Compatibility preferences restores the default word-chars value.

Screenshot

The new Word characters preference available in the Compatibility section.

Word characters preference

Closes #2304

@Davidy22 Davidy22 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a test to make sure it works, noticed that it doesn't immediately apply, only on next startup. May be unintuitive.

I was going to comment on the change to the comment as well but the shortened version grew on me on the second reading. Not sure why you did the label like that though, there are others with underscores but we have them conventionally at the front not middle.

Comment thread guake/data/prefs.glade
<object class="GtkLabel" id="word_chars_label">
<property name="visible">True</property>
<property name="can-focus">False</property>
<property name="label" translatable="yes">Word _characters:</property>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the underscore in the middle?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add editbox to tweak word-chars from preferences

2 participants