Fix various issues in package configuration file - #6617
Open
jhendersonHDF wants to merge 2 commits into
Open
jhendersonHDF wants to merge 2 commits into
jhendersonHDF wants to merge 2 commits into
Conversation
Fix find_dependency() calls so that PRIVATE-linked libraries are only propagated as transitive link requirements for static library targets Add missing find_dependency() calls for some PRIVATE-linked libraries Fix issue where parallel-enabled HDF5 can fail to locate MPI Fortran support, even when HDF5 Fortran support isn't requested Set HDF5_LIB_TYPE to only shared or static, depending on requested library type, rather than a list that could include both shared and static Fix HDF5_LIB_TYPE being undefined when components are specified, but shared/static isn't Reduce scope of modifications to CMAKE_MODULE_PATH so changes aren't propagated to consuming projects Add check for both shared and static libraries being requested and fail if so Remove enable_language() call in favor of checking enabled languages and failing if required language isn't enabled Add missing CMake variable for digitally signed plugins feature Fix CMake variable for HDF5_DIMENSION_SCALES_NEW_REF option
Contributor
Review ChecklistThis PR touches the following areas. Each needs a sign-off
|
This was
linked to
issues
Aug 17, 2026
Collaborator
Author
|
I manually tested the issues fixed by these changes, but plan to follow this up with a separate PR that adds testing of the installed .cmake files. |
jhendersonHDF
marked this pull request as ready for review
August 18, 2026 00:00
jhendersonHDF
requested review from
fortnern,
glennsong09,
hyoklee,
lrknox,
mattjala and
vchoi-hdfgroup
as code owners
August 18, 2026 00:00
github-actions
Bot
removed request for
fortnern,
hyoklee,
lrknox and
vchoi-hdfgroup
August 18, 2026 00:00
mattjala
reviewed
Aug 18, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix find_dependency() calls so that PRIVATE-linked libraries are only propagated as transitive link requirements for static library targets
Add missing find_dependency() calls for some PRIVATE-linked libraries
Fix issue where parallel-enabled HDF5 can fail to locate MPI Fortran support, even when HDF5 Fortran support isn't requested
Set HDF5_LIB_TYPE to only shared or static, depending on requested library type, rather than a list that could include both shared and static
Fix HDF5_LIB_TYPE being undefined when components are specified, but shared/static isn't
Reduce scope of modifications to CMAKE_MODULE_PATH so changes aren't propagated to consuming projects
Add check for both shared and static libraries being requested and fail if so
Remove enable_language() call in favor of checking enabled languages and failing if required language isn't enabled
Add missing CMake variable for digitally signed plugins feature
Fix CMake variable for HDF5_DIMENSION_SCALES_NEW_REF option