Skip to content

Fix various issues in package configuration file - #6617

Open
jhendersonHDF wants to merge 2 commits into
HDFGroup:developfrom
jhendersonHDF:fix_package_config_file_issues
Open

jhendersonHDF wants to merge 2 commits into
HDFGroup:developfrom
jhendersonHDF:fix_package_config_file_issues

Conversation

@jhendersonHDF

Copy link
Copy Markdown
Collaborator

Fix find_dependency() calls so that PRIVATE-linked libraries are only propagated as transitive link requirements for static library targets

Add missing find_dependency() calls for some PRIVATE-linked libraries

Fix issue where parallel-enabled HDF5 can fail to locate MPI Fortran support, even when HDF5 Fortran support isn't requested

Set HDF5_LIB_TYPE to only shared or static, depending on requested library type, rather than a list that could include both shared and static

Fix HDF5_LIB_TYPE being undefined when components are specified, but shared/static isn't

Reduce scope of modifications to CMAKE_MODULE_PATH so changes aren't propagated to consuming projects

Add check for both shared and static libraries being requested and fail if so

Remove enable_language() call in favor of checking enabled languages and failing if required language isn't enabled

Add missing CMake variable for digitally signed plugins feature

Fix CMake variable for HDF5_DIMENSION_SCALES_NEW_REF option

Fix find_dependency() calls so that PRIVATE-linked libraries are only
propagated as transitive link requirements for static library targets

Add missing find_dependency() calls for some PRIVATE-linked libraries

Fix issue where parallel-enabled HDF5 can fail to locate MPI Fortran
support, even when HDF5 Fortran support isn't requested

Set HDF5_LIB_TYPE to only shared or static, depending on requested
library type, rather than a list that could include both shared and
static

Fix HDF5_LIB_TYPE being undefined when components are specified, but
shared/static isn't

Reduce scope of modifications to CMAKE_MODULE_PATH so changes aren't
propagated to consuming projects

Add check for both shared and static libraries being requested and fail
if so

Remove enable_language() call in favor of checking enabled languages and
failing if required language isn't enabled

Add missing CMake variable for digitally signed plugins feature

Fix CMake variable for HDF5_DIMENSION_SCALES_NEW_REF option
@github-actions

github-actions Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Review Checklist

This PR touches the following areas. Each needs a sign-off
from its listed owners before merging.

@jhendersonHDF

Copy link
Copy Markdown
Collaborator Author

I manually tested the issues fixed by these changes, but plan to follow this up with a separate PR that adds testing of the installed .cmake files.

Comment thread release_docs/CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component - Build CMake files Component - Documentation Doxygen, markdown, etc.

Projects

Status: Planning

3 participants