Add image uploads to the email editor - #182
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The email editor currently requires authors to host images elsewhere and hand-write image tags. Add Upload & insert image to publish PNG, JPEG, or GIF banners to the existing public
HackIllinois/adonix-metadatarepository and insert responsive image HTML at the cursor. The preview and outgoing email use the same URL, pinned to the upload's GitHub commit so later uploads cannot replace images in sent emails.The upload endpoint verifies the user's ADMIN role with Adonix, enforces a 5 MB limit and image signature checks, and rejects private repositories. GitHub credentials remain on the server. The editor includes alt text, a copyable hosted URL, and upload errors, and prevents sending while an upload is in progress.
Deployment requires the server-only
EMAIL_IMAGES_GITHUB_TOKENsecret with Contents write access to the asset repository. Optional repository and branch overrides and local/Cloudflare setup are documented in the README. The existing bundled header/footer remain in place.Validation:
npm run build).npm test), covering authorization, size/type rejection, private repositories, GitHub/network failures, and HTML escaping.git diff --checkpassed.