fix(pivotGrid): Fix error thrown opening date pivot dimension filter. - #17480
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a runtime error in the Pivot Grid that occurs when opening a Date pivot dimension filter by deferring column regeneration triggered by i18n resource changes.
Changes:
- Defer
setupColumns()execution inside the i18nonResourceChangehandler via a microtask (Promise.resolve().then(...)).
Suppressed comments (1)
projects/igniteui-angular/grids/pivot-grid/src/pivot-grid.component.ts:1003
- The deferred
setupColumns()call is scheduled via a Promise microtask, which is not cancelled bydestroy$. If anonResourceChangeevent fires shortly before the grid is destroyed, this microtask can still run afterngOnDestroy, potentially invokingsetupColumns()on a destroyed instance.
Promise.resolve().then(() => {
this.setupColumns();
});
MayaKirova
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#17478
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
Pivot Grid
How Has This Been Tested?
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)