Skip to content

fix(pivotGrid): Fix error thrown opening date pivot dimension filter. - #17480

Merged
dkamburov merged 3 commits into
22.0.xfrom
skrastev/fix-pivot-error-22.0.x
Aug 4, 2026
Merged

fix(pivotGrid): Fix error thrown opening date pivot dimension filter.#17480
dkamburov merged 3 commits into
22.0.xfrom
skrastev/fix-pivot-error-22.0.x

Conversation

@skrustev

@skrustev skrustev commented Aug 3, 2026

Copy link
Copy Markdown
Member

#17478

Type of Change (check all that apply):

  • Bug fix
  • New functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes)
  • Documentation
  • Demos
  • CI/CD
  • Tests
  • Changelog
  • Skills/Agents

Component(s) / Area(s) Affected:

Pivot Grid

How Has This Been Tested?

  • Unit tests
  • Manual testing
  • Automated e2e tests

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them
  • Accessibility (ARIA, keyboard navigation, focus management) has been verified

Copilot AI review requested due to automatic review settings August 3, 2026 10:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a runtime error in the Pivot Grid that occurs when opening a Date pivot dimension filter by deferring column regeneration triggered by i18n resource changes.

Changes:

  • Defer setupColumns() execution inside the i18n onResourceChange handler via a microtask (Promise.resolve().then(...)).
Suppressed comments (1)

projects/igniteui-angular/grids/pivot-grid/src/pivot-grid.component.ts:1003

  • The deferred setupColumns() call is scheduled via a Promise microtask, which is not cancelled by destroy$. If an onResourceChange event fires shortly before the grid is destroyed, this microtask can still run after ngOnDestroy, potentially invoking setupColumns() on a destroyed instance.
                Promise.resolve().then(() => {
                    this.setupColumns();
                });

@skrustev skrustev added the squash-merge Merge PR with "Squash and Merge" option label Aug 3, 2026
@dkamburov dkamburov added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Aug 3, 2026
@dkamburov
dkamburov requested a review from MayaKirova August 3, 2026 13:23
@dkamburov
dkamburov merged commit e22567c into 22.0.x Aug 4, 2026
5 checks passed
@dkamburov
dkamburov deleted the skrastev/fix-pivot-error-22.0.x branch August 4, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

grid: pivot squash-merge Merge PR with "Squash and Merge" option version: 22.0.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants