refactor(triton): simplify JIT backend architecture - #925
Draft
voltjia wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JitBackend<device_type>template boundary.Motivation
This is a stacked cleanup of #800 focused on architecture, naming, modularity,
readability, and maintainability while preserving the template boundary needed
for future Triton backends.
The branch also carries the corresponding #919 changes because #800 has not
yet been rebased onto the master commit containing that merged PR.
Related: #800, #919
Type of Change
refactor- code restructuring without an intended public behavior changePlatforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
Validated commit
de9694aef9aef5bfb1c2705536b3d00592d6e318onaccelerator-dev/nvidia:latest(8 x A100-SXM4-80GB, CUDA 13.1.80,Python 3.12.3, Triton 3.5.1) against InfiniRT
0cdbb16967e15f2e055dea1ec9641617bf3b6cf6.Test Results on Supported Platforms
Benchmark / Performance Impact
N/A. This PR does not make a performance claim.
Notes for Reviewers
addoperator #800 comes from a fork, so GitHub cannot use its head directly as an upstream PR base.stack/pr-800-triton-backend-jitis an upstream mirror pinned to feat(triton): add JIT backend withaddoperator #800 head0c73a9e262291852ef7bccee67c65e0f85e555ac; this PR should be retargeted after feat(triton): add JIT backend withaddoperator #800 is rebased or merged.addoperator #800 is rebased onto currentmaster.Makeso derived config identity is not erased by the generic operator cache. Compiled kernels and auto-tuning results remain cached by their complete identities. Configless calls continue throughCall.pybind11::value_errorboundary so invalid binding input is exposed as PythonValueError.