update YAMLs and uber engine for DC AI 2026 - #1393
Open
baltzell wants to merge 2 commits into
Open
Conversation
baltzell
requested review from
c-dilks,
raffaelladevita and
zieglerv
as code owners
August 21, 2026 22:33
tongtongcao
reviewed
Aug 22, 2026
| public HitBasedAICV() { | ||
| super("HB","uber","1.0"); | ||
| add(new DCDenoiseEngine(), | ||
| new DCHBClustering(), |
Collaborator
There was a problem hiding this comment.
Is "new DCClsComboEngine()," missed?
Collaborator
Author
There was a problem hiding this comment.
That's not in etc/services/data-aicv.yaml. Should it be?
Collaborator
There was a problem hiding this comment.
HitBasedAICV includes DCHBTrackingAI. DCHBTrackingAI needs to get cluster combos from ai bank, and the ai bank is filled by DCClsComboEngine for cluster combo prediciton.
Is data-aicv.yaml for both conventional and old AI-assisted tracking?
In data-aicv.yaml, MLTDEngine is applied. That is the old engine for cluster combo prediction.
Collaborator
Author
There was a problem hiding this comment.
The uber engines were just copied from the YAMLs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.