Tracking update jun26 - #1147
Merged
Merged
Conversation
…y sorting of hits before adding as associated objects and remove unnessary temperory vectors before getting the hit bit patterns.
…irebased stage to feed to the timebased stage. Get the hits from the associated objects attached to the wire-based track only when necessary.
…thod with a method that gets a single t0. Use revised argument list for FitTrack methods to reflect this change.
…ode and to make sure Richard's optional code filling dEdx vectors gets called in every context.
…y. Adjust some t0_sigma values.
…n the FitWithWireBasedHits method.
… position matching condition. Remove OUT_OF_TIME cut in these contexts, because at this stage of the reconstruction, the time to which the calculated start time is compared comes from the minimum drift time, which could be several tens of ns or even more depending on the minimum doca to the wires.
|
Test status for this pull request: SUCCESS Summary: summary.txt Build log: make_TrackingUpdateJun26.log |
Contributor
|
I made a quick test with 2017 data and 16 threads and got the following results:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More cleanup of the code: Remove vector of start times from the DTrackTimeBased object and a corresponding histogram. This was used during the early development stage and is no longer needed. Remove some duplicate code in the part of the code that finds the dEdx on the track; this change also makes sure Richard's optional dEdx vector gets called in each context. Make sure the t0 sigma gets passed on through each stage of the tracking code. Explicitly disable DIRC matching when in fast tracking mode. Get rid of out-of-time cut when finding a guess for t0: this was always flawed because the time to which the guess for t0 (as computed using the flight time to the fast detectors) is compared was derived from the earliest drift time in the chambers of the hits on the track, which could be tens of ns or more depending on the smallest distance to the wires. The cut is still present for later stages of the reconstruction/analysis, but I effectively disable this for the fast tracking mode. This change recovers most of the missing efficiency in p2pi reconstruction for the fast tracking mode.