Extract skiko platform code into separate module by hub-bla · Pull Request #1292 · JetBrains/skiko

Hubert Błaszczyk (hub-bla) · 2026-09-07T10:59:45Z

This branch introduces a new skiko-rendering module that separates platform rendering integration from the core skiko library.

The new module owns the higher-level rendering infrastructure, including SkiaLayer, frame dispatching, render delegates, AWT/Swing integration, platform renderers, ANGLE support.

Fixes SKIKO-1189

Igor Demin (igordmn)

Only skiko/README.md needs to be updated

Igor Demin (igordmn) · 2026-10-05T21:27:06Z

Please adopt the new changes from master

…initializeCAccessible

Igor Demin (igordmn)

Found new issues with AI help. Some are not trivial, but they might cause Major/Critical regressions, so it is better to check.

Igor Demin (igordmn) · 2026-10-27T18:21:59Z

@@ -115,9 +115,8 @@ + (instancetype)sharedCache {



This file contains MetalOffscreenContext related functions. We should either move them back to the core library, where the Kotlin class lives, or move the Kotlin class to the skiko-platform (probably we should do this, as we did with DirectXOffscreenContext).

The same for OpenGLOffscreenContext.

Igor Demin (igordmn) · 2026-10-27T18:30:03Z

 #include <dxgi1_6.h>

 // Set in JNI_OnLoad (jvmMain/cpp/common/impl/Library.cc).
 extern "C" JavaVM *jvm;


After moving this into a new dll, all extern variables may stop working. Can you check this?

You can check it resizing a window on Windows with System.setProperty("skiko.rendering.windows.direct3DSynchronousLiveResize", "true")

If it crashes, we should find all moved extern's and fix it somehow.

Igor Demin (igordmn) · 2026-10-27T18:38:23Z

        skikoArtifacts.jvmAdditionalRuntimeArtifactIdFor("angle", OS.Windows, Arch.X64),
        skikoArtifacts.jvmAdditionalRuntimeArtifactIdFor("angle", OS.Windows, Arch.Arm64),


skikoArtifacts.jvmAdditionalRuntimeArtifactIdFor("angle", OS.Windows, Arch.X64),

They seem no longer exist? If so, we should remove these lines

Igor Demin (igordmn) · 2026-10-27T18:44:22Z

        val commonMain by getting {
            dependencies {
                implementation(libs.skiko)
+                implementation(libs.skiko.platform)


Probably we need to add it to benchmarks too. Desktop compilation may fail because it imports DirectXOffscreenContext

Igor Demin (igordmn) · 2026-10-27T18:54:04Z

This test uses Library.load(), we should probably replace it by PlatformLibrary.load()

Igor Demin (igordmn) · 2026-10-27T20:37:06Z

+val coreProject = project(":")
+
+val platformDependencies: SkikoDependencyScope.() -> Unit = {
+    dependsOnCore()


There is a hypothetical issue for an important Desktop use-case (it might exists in real plugins right now). Not sure if it is real, but worth to check (see an old IntelliJ plugin example)

IntelliJ plugin A uses Skiko 0.100.0
IntelliJ plugin B uses Skiko 0.102.0

skiko-platform 0.100.0, directXRenderer.cc calls throwJavaRenderExceptionByExceptionCode, which is inside skiko 0.100.0

skiko-platform 0.102.0, directXRenderer.cc calls renamed throwJavaRenderExceptionByException, which is inside skiko 0.102.0

But skiko-platform 0.102.0 is linked against a name skiko-windows-x64, and if we have an old Skiko already loaded, it might be linked against 0.100.0 and we have a crash.

We have a fix for it for System.load, but it probably doesn't work for build-time linking

Igor Demin (igordmn) · 2026-10-27T20:54:27Z

    implementation("org.jetbrains.runtime:jbr-api:1.5.0")
    if (System.getProperty("os.name").startsWith("Win")) {
-        implementation("org.jetbrains.skiko:skiko-awt-runtime-angle-$target:$version")
+        implementation("org.jetbrains.skiko:skiko-platform-awt-runtime-angle-$target:$version")


We should update the doc for val renderingAngleEnabled: Boolean

Igor Demin (igordmn) · 2026-10-27T21:02:11Z

+
+private val platformLoader = LibraryLoader(
+    name = "skiko-platform-$hostId",
+    init = { Setup.init() },


Suggested change

init = { Setup.init() },

init = { Setup.init() },

cls = PlatformLibrary::class.java,

should we pass it and use here?

private fun getModuleResourceAsStream(resourceName: String) = Library::class.java.classLoader.getResourceAsStream(resourceName)

Igor Demin (igordmn) · 2026-10-27T21:17:43Z

We move classes into another module, but don't change its package to org.jetbrains.skiko.platform, so both modules use name org.jetbrains.skiko.

For compatibility reasons, I would keep it this way, but can it cause issues with JPMS? Can it cause issues with planned work in #1323 (comment)?

Hubert Błaszczyk (hub-bla) force-pushed the hub.bla/skiko-rendering-module branch 3 times, most recently from ca727bc to 660f7ae Compare September 7, 2026 12:10

Hubert Błaszczyk (hub-bla) force-pushed the hub.bla/skiko-rendering-module branch 2 times, most recently from 098c342 to 03108b0 Compare September 7, 2026 13:07

Hubert Błaszczyk (hub-bla) force-pushed the hub.bla/skiko-rendering-module branch from 03108b0 to c41b90c Compare September 9, 2026 09:14

Base automatically changed from hub.bla/decouple-ganesh-from-platform-redrawers to master September 9, 2026 09:36

Hubert Błaszczyk (hub-bla) force-pushed the hub.bla/skiko-rendering-module branch 5 times, most recently from 94198bd to 9218f96 Compare September 11, 2026 11:15

Hubert Błaszczyk (hub-bla) marked this pull request as ready for review September 14, 2026 08:54

Hubert Błaszczyk (hub-bla) requested review from Ivan Matkov (MatkovIvan) and Igor Demin (igordmn) September 16, 2026 11:24

Igor Demin (igordmn) reviewed Sep 17, 2026

View reviewed changes

Comment thread skiko/settings.gradle.kts

Comment thread skiko/skiko-rendering/src/awtMain/kotlin/org/jetbrains/skiko/renderer/MetalRenderer.kt Outdated

Comment thread skiko/settings.gradle.kts Outdated

Hubert Błaszczyk (hub-bla) changed the title ~~Extract skiko rendering code into separate module~~ Extract skiko platform code into separate module Sep 21, 2026

Igor Demin (igordmn) approved these changes Sep 21, 2026

View reviewed changes

Igor Demin (igordmn) approved these changes Sep 22, 2026

View reviewed changes

Hubert Błaszczyk (hub-bla) force-pushed the hub.bla/skiko-rendering-module branch from 73c1bbc to 8f04872 Compare September 30, 2026 09:01

Hubert Błaszczyk (hub-bla) force-pushed the hub.bla/skiko-rendering-module branch from 8f04872 to 4b52e55 Compare October 6, 2026 07:11

Hubert Błaszczyk (hub-bla) commented Oct 6, 2026

View reviewed changes

Comment thread skiko/skiko-platform/src/jvmMain/kotlin/org/jetbrains/skiko/Setup.kt Outdated

Igor Demin (igordmn) requested changes Oct 6, 2026

View reviewed changes

Hubert Błaszczyk (hub-bla) force-pushed the hub.bla/skiko-rendering-module branch from cfc2fcc to 58b3e65 Compare October 7, 2026 07:10

Igor Demin (igordmn) reviewed Oct 7, 2026

View reviewed changes

Comment thread samples/SkiaAwtSample/build.gradle.kts

Hubert Błaszczyk (hub-bla) force-pushed the hub.bla/skiko-rendering-module branch from 58b3e65 to b80f7ce Compare October 27, 2026 12:43

Hubert Błaszczyk (hub-bla) and others added 14 commits October 27, 2026 13:51

Prepare skiko core for rendering extensions

dced964

Extract rendering infrastructure into skiko-rendering

ec3877d

Move rendering tests to skiko-rendering

085e44f

Update samples and documentation for skiko-rendering

02aed1f

Rename skiko-rendering to skiko-platform

64eb826

Load platform library before standalone native calls in JumpList and …

8bb8d31

…initializeCAccessible

Document new module in README.md

dee0353

Move native frame pacing to skiko-platform

54387d9

Publish platform runtimes from runtime-publications

5252d41

Use Kotlin Native API version for platform bindings

78c75fe

Discover additional runtime publications lazily

0f406d7

Configure additional runtime publications as configurations appear

19b1441

Restore attribute-based additional runtime publishing

1e80d40

Disable composite substitution in AWT sample

ecf4654

Hubert Błaszczyk (hub-bla) force-pushed the hub.bla/skiko-rendering-module branch from b80f7ce to ecf4654 Compare October 27, 2026 13:14

Igor Demin (igordmn) reviewed Oct 27, 2026

View reviewed changes

	init = { Setup.init() },
	init = { Setup.init() },
	cls = PlatformLibrary::class.java,

Conversation

Hubert Błaszczyk (hub-bla) commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Igor Demin (igordmn) left a comment

Choose a reason for hiding this comment

Uh oh!

Igor Demin (igordmn) commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Igor Demin (igordmn) left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Hubert Błaszczyk (hub-bla) commented Sep 7, 2026 •

edited

Loading

Igor Demin (igordmn) commented Oct 5, 2026 •

edited

Loading