Repository navigation
Add a macOS Kotlin/Native target to the Skiko benchmarks - #1336
Merged
Ivan Matkov (MatkovIvan) merged 5 commits intoOct 26, 2026
Merged
Conversation
Ivan Matkov (MatkovIvan)
requested review from
Igor Demin (igordmn) and
Dustin Feucht (nopjar)
October 23, 2026 08:44
Igor Demin (igordmn)
requested changes
Oct 23, 2026
Co-authored-by: Igor Demin <igordmn@users.noreply.github.com>
Each publish dry run publishes only part of skiko, so the skiko dependency of commonMain did not resolve for the targets of the other platforms. The web targets now follow skiko.wasm.enabled and the macOS target follows skiko.native.enabled, and run_benchmarks.main.kts sets both for every run. Without these properties all targets stay declared. Web runs against the current checkout also build the skiko JVM variant, because the result server runs on the jvm target.
Igor Demin (igordmn)
approved these changes
Oct 26, 2026
Ivan Matkov (MatkovIvan)
deleted the
ivan.matkov/skiko-benchmarks-native
branch
October 26, 2026 13:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was required to test #1332
macosArm64target that runs the shared benchmark suite as a Kotlin/Native executable.run_benchmarks.main.kts macos version=<skiko-version>runs it like the other platforms, through the newmacosBenchmarkGradle task.