Skip to content

Don't send Postman query params twice - #220

Open
jayhemnani9910 wants to merge 1 commit into
Julien-cpsn:mainfrom
jayhemnani9910:fix/postman-query-params-once
Open

jayhemnani9910 wants to merge 1 commit into
Julien-cpsn:mainfrom
jayhemnani9910:fix/postman-query-params-once

Conversation

@jayhemnani9910

Copy link
Copy Markdown

Requests imported from a Postman collection send their query parameters twice. Postman stores both the raw URL and the query list:

"url": {
  "raw": "https://api.example.com/orders?status=open",
  "query": [{ "key": "status", "value": "open" }]
}

The importer keeps raw as the request URL and also fills the params from query. ATAC adds the params to the URL when it sends, so the request goes out as /orders?status=open&status=open (seen on a local server).

When the query list is used, the query part is now removed from the stored URL, so the params are the only source, as for requests made in ATAC.

Added a unit test on parse_request; it fails without the change. cargo test passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant