Repository navigation
refactor: upgrade to react 19 - #440
Conversation
Co-Authored-By: kyusho <antoineyang99@gmail.com> (cherry picked from commit 3a34047)
(cherry picked from commit 706eca5bcf26282853f0c567f3aff232d2ebd21a)
Replace Fluent/Fabric components and icon fonts with Radix/shadcn primitives and Lucide icons, remove the legacy account/logging layer, add migration gates, and harden shared table behavior including virtualization.
Replace the custom application navigation shell with the shadcn Sidebar composition, preserve grouped navigation and shortcuts, and add responsive Sheet behavior with React 18 and Tailwind 3 compatibility.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5462415caa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| await page.goto('/', { waitUntil: 'networkidle' }); | ||
| await page.getByRole('button', { name: /Create DataSource/i }).click(); | ||
| await page.getByText('Demo', { exact: true }).click(); | ||
| await page.getByRole('gridcell', { name: /^Cars\b/ }).click(); |
There was a problem hiding this comment.
The demo chooser was migrated in packages/rath-client/src/pages/dataSource/selection/demo.tsx from role="gridcell" items to styled <button> cards, so this smoke test will never find getByRole('gridcell', { name: /^Cars\b/ }) and yarn test:smoke times out before loading the dataset. Query the Cars card as a button, or restore the grid/gridcell roles, so the new CI gate can pass.
Useful? React with 👍 / 👎.
| return <SelectLabel key={option.key}>{option.text}</SelectLabel>; | ||
| } | ||
| return ( | ||
| <SelectItem key={option.key} value={optionValue(option)} disabled={option.disabled}> |
There was a problem hiding this comment.
Radix Select reserves the empty string value for clearing/placeholder state, but RathSelect forwards every option key verbatim; converted callsites still pass empty-key options such as fieldOptions in encodeCreationPill.tsx and the not_chosen/None options in RExplainer.tsx. Opening any of those selects will throw instead of rendering, so map empty keys to a non-empty sentinel before passing value to SelectItem and translate it back in onChange.
Useful? React with 👍 / 👎.
| branches: [master, dev] | ||
| pull_request: | ||
| branches: [main, dev] | ||
| branches: [master, dev] |
There was a problem hiding this comment.
This workflow used to run on main, and this checkout still has a main branch with no master ref; after changing both branch filters to master, pushes and pull requests targeting main will no longer run the React 19 build/test gates added below. Unless the repository default branch is being renamed in the same rollout, include main here so the auto-build continues to protect the active branch.
Useful? React with 👍 / 👎.
No description provided.