ci: correct why the version PR needs approving - #8
Merged
Conversation
The first real release proved the reasoning in these comments wrong, so they now record what was observed rather than what was assumed. The claim was that a pull request opened with GITHUB_TOKEN does not fire `pull_request`, and that the `push: release/**` trigger is what gets checks onto the version pull request. Neither half held on v0.1.0. The push started nothing — GITHUB_TOKEN cannot start a workflow — so that trigger never fired at all. The pull request did start a run, which GitHub then held as `action_required` because the actor is `github-actions[bot]`. So the checks do report, after one approval click per release. No repository-level setting to waive that is exposed, and a release is already a deliberate act, so it stays. The push trigger is kept, with its real purpose written down: a person pushing a fixup to a release branch, which does fire and would otherwise get no checks at all.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe workflow comments now document observed GitHub Actions behavior for release pushes and bot-created version pull requests. The ChangesWorkflow trigger documentation
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to This comments-only change documents the approval required for version pull requests without changing workflow behavior, so no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first real release exercised the version write-back path for the first time, and it did not behave the way these comments said it would. They now record what was observed.
What the comments claimed
…and therefore that the
push: release/**trigger is what puts the three required checks onto the version pull request.What actually happened on v0.1.0
pushtorelease/v0.1.0pull_requestfor #7action_requiredbecause the actor isgithub-actions[bot]Confirmed from the API rather than inferred:
So half the reasoning was right — GITHUB_TOKEN work does not start runs — and the conclusion drawn from it was wrong. The
pushtrigger has never fired and never will for release.yml's own push; the mechanism is thepull_requestrun, gated behind one approval.What changes
Comments only; no behaviour. Both files now say that the version pull request needs one approval click in the Actions tab per release, and why. I checked whether that gate can be waived —
repos/…/actions/permissionsexposes no approval policy, and the org endpoint needs a scope I do not have — so it is documented rather than worked around. A release is a deliberate act already.The
push: release/**trigger is kept, with its real purpose written down: a person pushing a fixup to a release branch does fire it, and would otherwise get no checks at all.Summary by CodeRabbit