Repository navigation
Add support for building CTS natively on Windows - #2722
Open
jujiang-del wants to merge 26 commits into
Open
jujiang-del wants to merge 26 commits into
jujiang-del wants to merge 26 commits into
Conversation
rjodinchr
approved these changes
Jun 12, 2026
rjodinchr
self-requested a review
June 12, 2026 05:13
rjodinchr
reviewed
Jun 12, 2026
rjodinchr
requested changes
Jun 29, 2026
rjodinchr
removed their request for review
July 1, 2026 06:04
rjodinchr
reviewed
Jul 1, 2026
rjodinchr
left a comment
rjodinchr
left a comment
Collaborator
There was a problem hiding this comment.
Fine as far as I can see. We need some people involved with windows to review
rjodinchr
self-requested a review
July 1, 2026 06:06
bashbaug
reviewed
Sep 15, 2026
Contributor
Author
|
Thanks for the review and suggestion. Updated accordingly. |
Adds a build-windows-msys2 job following the new Windows build instructions in README.md, and bumps actions/checkout to v7. Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
rjodinchr
reviewed
Oct 2, 2026
rjodinchr
requested changes
Oct 6, 2026
rjodinchr
reviewed
Oct 7, 2026
rjodinchr
reviewed
Oct 8, 2026
| compilation of OpenCL-C source code. This executable must match the | ||
| [interface description](test_common/harness/cl_offline_compiler-interface.txt). | ||
|
|
||
| ## Running the CTS |
Collaborator
There was a problem hiding this comment.
Why did you move that section here? ### Offline Compilation is a subsection of ## Running the CTS, with this change, it is not anymore and I don't see any reason for that.
I'm sorry that this part of the review takes that long. Do you mind if I modify that PR myself?
Contributor
Author
There was a problem hiding this comment.
No I don't mind. Really appreciate if you modify.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding instructions and support to build CTS on Windows using MSYS2 gcc.