Repository navigation
Conversation
rjodinchr
commented
Oct 6, 2026
rjodinchr
commented
Collaborator
- Move function_list.{cpp,h} from math_brute_force to test_common/harness.
- Update spir to compile function_list.cpp with FUNCTION_LIST_ULPS_ONLY instead of including the .cpp file in main.cpp.
- Update math_brute_force and spir CMakeLists and includes accordingly.
- Fix subgroups including mt19937.cpp instead of mt19937.h.
- Move function_list.{cpp,h} from math_brute_force to test_common/harness.
- Update spir to compile function_list.cpp with FUNCTION_LIST_ULPS_ONLY
instead of including the .cpp file in main.cpp.
- Update math_brute_force and spir CMakeLists and includes accordingly.
- Fix subgroups including mt19937.cpp instead of mt19937.h.
svenvh
reviewed
Oct 8, 2026
svenvh
left a comment
svenvh
left a comment
Member
There was a problem hiding this comment.
LGTM but maybe rename to math_function_list.{h,cpp} to make it clear that these are the math functions only?
svenvh
reviewed
Oct 8, 2026
svenvh
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.