Skip to content

docs(lavaflow): describe normal repository CI for person-reviewed fixes - #197

Open
swkeever wants to merge 5 commits into
mainfrom
skeever/lavaflow-normal-pr-ci
Open

swkeever wants to merge 5 commits into
mainfrom
skeever/lavaflow-normal-pr-ci

Conversation

@swkeever

@swkeever swkeever commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

With autonomy: open_pr, describe LavaFlow opening reviewed fixes ready for review and letting normal repository CI run, without a workflow approval label or CI-skip marker. Keep automatic merging and the previous publication path documented separately.

Platform: https://github.com/Kong/volcano-hosting/pull/3447.
Repository CI: https://github.com/Kong/volcano-web/pull/1214.
Rollout configuration: https://github.com/Kong/volcano-runtime-config/pull/100. Merge this documentation only after compatible hosting and its normal-CI rollout configuration reach production.

Validation: pnpm lint (existing warnings only), pnpm lint:docs content, pnpm check:links, and pnpm build pass.

@swkeever
swkeever marked this pull request as ready for review November 16, 2026 18:06
Copilot AI balanced review requested due to automatic review settings November 16, 2026 18:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

AI review: no P0-P2 findings

Reviewed 6ec613b. Run log

This docs-only change describes LavaFlow's normal repository CI for fixes a person merges and keeps the automatic-merge and earlier publication paths documented separately. Both earlier findings are fixed at this head: Code Quality's review-before-open rule now matches its own section, and the CLI page and the "Gate workflows that run a fix" preface now say "any fix LavaFlow leaves a person to merge, in any autonomy". Risk is low. One minor gap remains: the CLI page doesn't warn about secrets for open_pr. The page must not publish before the hosting rollout reaches production.

⚪ P3

  • content/cli/lavaflow.md:265 The CLI page warns about CI with secrets only for merge, not for open_pr fixes on normal repository CI

Not checked: The AI review read the diff, the code, and the PR's text; it ran no tests or builds and read nothing outside this repository.

  • Whether Kong/volcano-hosting#3447 and Kong/volcano-runtime-config#100 are in production; a push to main publishes these pages right away.
  • Whether a merge project's fix that is held when it opens (such as for path) gets normal repository CI or stays on the CI-skip path.
  • Which repository_checks.message second sentence a normal-CI fix reports, and whether such a fix is still recorded as held with person_merges.
  • Confirm Kong/volcano-hosting#3447 and Kong/volcano-runtime-config#100 are deployed to production and match the documented publication, Code Quality, capability, and CI-reporting behavior before these…

Human review: not needed

Comment thread content/platform/guides/lavaflow.md Resolved
Comment thread content/platform/guides/lavaflow.md Resolved
Comment thread content/platform/guides/lavaflow.md Resolved
Comment thread content/platform/guides/lavaflow.md Resolved
Comment thread content/platform/guides/lavaflow.md Resolved
Comment thread content/platform/guides/lavaflow.md Resolved
Comment thread content/cli/lavaflow.md
### Allow ungated workflows

By default, LavaFlow doesn't open a fix's pull request where a workflow in
Normal repository CI for any fix LavaFlow leaves a person to merge does not need this setting, in any autonomy: LavaFlow opens the PR and lets the repository run its configured CI.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ P3: The CLI page warns about CI with secrets only for merge, not for open_pr fixes on normal repository CI

The guide's intro and the "Review and merge fixes yourself" section now warn that, on normal repository CI, CI may run model-generated code with repository secrets before anyone reviews it. The new CLI text at line 265 says only that LavaFlow "lets the repository run its configured CI". The page's one secrets warning is still the one tied to --autonomy merge (lines 198–199): "Turning on merge lets LavaFlow's fixes, including those from runs it starts on its own, run your CI with the secrets". On the new path, runs LavaFlow starts on its own already reach CI with secrets without merge, because they only open a pull request for a person to merge. A reader who stays on the default open_pr after reading only the CLI page may think that choice keeps fixes away from CI with secrets. Fix: add the guide's one-sentence caution to line 265, or to the open_pr bullet under "Choose how far it goes", and link to the guide's approval-label example. The same applies to guide line 932, which line 936 only partly qualifies.

Found by claude-opus-5-5

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants