Repository navigation
Conversation
AI review: no P0-P2 findingsThis docs-only change describes LavaFlow's normal repository CI for fixes a person merges and keeps the automatic-merge and earlier publication paths documented separately. Both earlier findings are fixed at this head: Code Quality's review-before-open rule now matches its own section, and the CLI page and the "Gate workflows that run a fix" preface now say "any fix LavaFlow leaves a person to merge, in any autonomy". Risk is low. One minor gap remains: the CLI page doesn't warn about secrets for ⚪ P3
Not checked: The AI review read the diff, the code, and the PR's text; it ran no tests or builds and read nothing outside this repository.
Human review: not needed |
| ### Allow ungated workflows | ||
|
|
||
| By default, LavaFlow doesn't open a fix's pull request where a workflow in | ||
| Normal repository CI for any fix LavaFlow leaves a person to merge does not need this setting, in any autonomy: LavaFlow opens the PR and lets the repository run its configured CI. |
There was a problem hiding this comment.
⚪ P3: The CLI page warns about CI with secrets only for merge, not for open_pr fixes on normal repository CI
The guide's intro and the "Review and merge fixes yourself" section now warn that, on normal repository CI, CI may run model-generated code with repository secrets before anyone reviews it. The new CLI text at line 265 says only that LavaFlow "lets the repository run its configured CI". The page's one secrets warning is still the one tied to --autonomy merge (lines 198–199): "Turning on merge lets LavaFlow's fixes, including those from runs it starts on its own, run your CI with the secrets". On the new path, runs LavaFlow starts on its own already reach CI with secrets without merge, because they only open a pull request for a person to merge. A reader who stays on the default open_pr after reading only the CLI page may think that choice keeps fixes away from CI with secrets. Fix: add the guide's one-sentence caution to line 265, or to the open_pr bullet under "Choose how far it goes", and link to the guide's approval-label example. The same applies to guide line 932, which line 936 only partly qualifies.
Found by claude-opus-5-5
With
autonomy: open_pr, describe LavaFlow opening reviewed fixes ready for review and letting normal repository CI run, without a workflow approval label or CI-skip marker. Keep automatic merging and the previous publication path documented separately.Platform: https://github.com/Kong/volcano-hosting/pull/3447.
Repository CI: https://github.com/Kong/volcano-web/pull/1214.
Rollout configuration: https://github.com/Kong/volcano-runtime-config/pull/100. Merge this documentation only after compatible hosting and its normal-CI rollout configuration reach production.
Validation:
pnpm lint(existing warnings only),pnpm lint:docs content,pnpm check:links, andpnpm buildpass.