You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Missing route waits on multicluster tests routes require additional investigation and issues opened
The default route fixture in testsuite/tests/singlecluster/conftest.py does not call wait_for_ready() after commit(). This was missed when the method was added to HTTPRoute.
Adding the call directly causes some tests to fail and needs investigation.
Changes needed
1. Add no-op wait_for_ready() to EnvoyVirtualRoute
EnvoyVirtualRoute lacks a wait_for_ready() method, so calling it unconditionally on the route fixture would break standalone Authorino tests. Add the following placeholder matching the existing commit()/delete() pattern:
3. Investigate and fix test failures triggered by the wait
Some tests fail when the wait is added. These need to be investigated and fixed before merging.
Note
Missing route waits on multicluster tests routes require additional investigation and issues opened
The default
routefixture intestsuite/tests/singlecluster/conftest.pydoes not callwait_for_ready()aftercommit(). This was missed when the method was added toHTTPRoute.Adding the call directly causes some tests to fail and needs investigation.
Changes needed
1. Add no-op
wait_for_ready()toEnvoyVirtualRouteEnvoyVirtualRoutelacks await_for_ready()method, so calling it unconditionally on the route fixture would break standalone Authorino tests. Add the following placeholder matching the existingcommit()/delete()pattern:2. Add
wait_for_ready()to the singlecluster route fixture3. Investigate and fix test failures triggered by the wait
Some tests fail when the wait is added. These need to be investigated and fixed before merging.