fix: correct zoneinfo typo and clone path in arch scripts - #2
Draft
LJLee37 wants to merge 1 commit into
Draft
Conversation
- install1.sh linked /mnt/usr/share/zoneifno instead of zoneinfo, which made the timezone symlink step fail during install. - set.sh hard-coded ~/gitRepos/Personal/settingfiles while README says to clone to ~/gitRepos/settingfiles; standardize on the README path. Also document the branch-per-OS layout and this branch's multi-stage install order in README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of a repo-wide cleanup (companion PRs on
master,macOS,ubuntu,alpine,raspi, plus a newraspi-archbranch for Arch Linux ARM).install1.shlinked/mnt/usr/share/zoneifno/Asia/Seoul(typo) instead ofzoneinfo, so the timezone symlink step silently failed during install. Fixed the typo.set.shhard-coded~/gitRepos/Personal/settingfileswhile README instructs cloning to~/gitRepos/settingfiles, so following the README brokeset.shon this branch. Standardized on~/gitRepos/settingfiles.masterPR for the full rationale), plus a short "install order" section documenting howinstall1.sh→install2.sh→set.sh→ optionalinstall-gnome.sh/install-graphical-programs.sh/install-steam.sh/set-hibernate.shfit together — this wasn't documented anywhere before.No other content changes —
.vimrc/.zshrc/init.vimare untouched.Hardcoded personal values (found on this branch, left untouched)
Not removed or parameterized per the task — flagging for the repo owner to decide:
user.name "LJLee37",user.email "ljlee3759@gmail.com"(set.sh)rpi.ljlee37.com/-P 3759(set.sh)LJLeeLT, usernameljlee(install2.sh)bc22c8a5-306c-4ad3-81c3-753aff6f562d(set-hibernate.sh)ko_KR/ja_JP/eo(install2.sh)Test plan
grep -n zoneinfo install1.shshows the fixed pathgrep -n 'gitRepos/settingfiles' set.shshows bothcplines updated, no remainingPersonal/referencesGenerated by Claude Code