[fAnselmi-Ledger]

📝 Description

Fixes stale and misleading comments in the signer-solana clear-sign code. Comments and test titles only: no code changes. Stacked on #1990.

Wrong claim about the device

• Three comments (buildRequirements.ts, model.ts and a buildRequirements test) said the device "signals 0x6d10" for ALT-backed mints and "requires TOKEN_INFO immediately after". In app-solana, 0x6d10 is ApduReplySolanaInvalidAltResolution ("Invalid ALT resolution descriptor"). handle_provide_alt_resolution.c returns it only to reject an ALT_RESOLUTION descriptor: bad TLV, wrong version, challenge mismatch, failed signature, or a full or duplicate ALT cache. It is never a request for TOKEN_INFO, and the host never reacts to it.
• The replacement describes what the host does: the provide phase streams the ALT_RESOLUTION, then the resolved mint's TOKEN_INFO (best-effort, skipped when that mint was already streamed). The same goes for the "hold-and-conditionally-stream" wording in BuildGeneric: nothing is held back.

Docs that described the code wrongly

• ProvideGeneric provideDescriptor: fatal failures abort by returning the failed result, not "by throwing". A test already asserts that run() does not reject.
• ProvisionBasic class doc: there is no GetPubKey step and no transaction-check gate. The machine inspects when SPL is supported, then builds and provides for SPL or swap transactions.
• loadCertificateIfPresent: not every provider needs this gate. TOKEN skips its whole descriptor without a certificate, and calls loadCertificate directly.
• provideTokenAccountStateContext: the caller is ProvideGenericClearSignContextTask, not a "stream task".
• poolFromJson / parsePool: both said "@throws never" but do throw TypePoolDecoderThrow. For poolFromJson, the doc now says that buildRequirements' catch-all turns the throw into a RequirementsDecodeError.
• TypePoolDecoder: nothing checks cursorEnd, so the comment no longer says the "cursor-end check" catches unread bytes.
• accountAltRefAt: "exactly one of the two answers" holds only for an in-range slot. Both are undefined out of range.
• altResolutionRule: drops a changelog-style "now".

Old vocabulary

• srfc39-only is never produced. BuildGeneric's mode doc says so, and the public ClearSignMode JSDoc gets "(not produced today)". The type itself is unchanged.
• SignTransactionDeviceAction.test.ts: four "armed" / "alreadyArmed" test titles and two test comments now say "provisioned", and the header no longer mentions a "(delayed) terminal-sign machine". Only titles and comments change; no assertion is touched.

Left alone on purpose

• The ProvideGeneric "shows ???" comments: which device behaviour is current is still an open firmware question.
• The [SigningOps] log prefix: changing it would change a log.

❓ Context

• JIRA or GitHub link: DSDK-1611
• Feature: Solana signer clean-up, stale comments in clear-sign. Stacked on ⚰️ (signer-solana) [DSDK-1608]: Remove dead code from the clear-sign tasks #1990 → ⚰️ (signer-solana) [DSDK-1607]: Pin golden command APDUs and remove command dead code #1986 → ⚰️ (signer-solana) [DSDK-1606]: Remove dead code from the clear-sign and parser modules #1984 → ✅ (signer-solana) [DSDK-1603]: Pin the generic clear-sign stream timeline #1979.
• Side finding (not in this PR): the app's 0x6d10 is missing from the signer's SOLANA_APP_ERRORS, so the host reports it as an unknown device error. Adding it changes error behaviour, so it belongs in its own ticket.

✅ Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

• Covered by automatic tests: no code change. The full suite passes unchanged, including the pinned timeline and golden tests.
• Changeset is provided: patch for @ledgerhq/device-signer-kit-solana
• Documentation is up-to-date
• Impact of the changes:
  • Comments and test titles only. tsc, vitest and Prettier are green on signer-solana.
  • Nothing for QA to check.

---

🧐 Checklist for the PR Reviewers

• The code aligns with the requirements described in the linked JIRA or GitHub issue.
• The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
• There are no undocumented trade-offs, technical debt, or maintainability issues.
• The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
• Any new dependencies have been justified and documented.

🤖 Generated with Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
device-sdk-ts-sample	Ready	Preview	Oct 23, 2026 3:42pm UTC
doc-device-management-kit	Ready	Preview	Oct 23, 2026 3:42pm UTC

[Copilot]

🟢 Approval recommended

The documentation-only updates accurately reflect the inspected implementation and introduce no unresolved issues.

0 open findings

What changed in this PR

Updates stale Solana clear-sign documentation and test titles without changing runtime behavior.

Changes:

• Corrects descriptor provisioning, ALT resolution, and decoder documentation.
• Clarifies clear-sign modes and basic provisioning behavior.
• Replaces outdated “armed” terminology with “provisioned.”

File	Description
.changeset/​rumbling-red-keys.md	Adds the signer-solana patch changeset.
ProvideGenericClearSignContextTask.ts	Corrects fatal-failure behavior documentation.
provideTokenAccountStateContext.ts	Names the actual caller.
loadCertificate.ts	Clarifies optional-certificate handling.
BuildGenericClearSignContextTask.ts	Corrects ALT mint and mode documentation.
SignTransactionDeviceAction.test.ts	Updates terminology in test titles and comments.
ProvisionBasicClearSignDeviceAction.ts	Corrects the provisioning workflow description.
valueResolution.ts	Documents out-of-range lookup behavior.
altResolutionRule.ts	Removes changelog-style wording.
model.ts	Corrects ALT-backed mint behavior documentation.
buildRequirements.ts	Corrects mint requirement comments.
buildRequirements.test.ts	Updates the corresponding test comment.
TypePoolDecoder.ts	Corrects unread-payload behavior documentation.
poolFromJson.ts	Documents thrown decoder errors and conversion.
parsePool.ts	Corrects the function’s throw contract.
SignTransactionDeviceActionTypes.ts	Notes that srfc39-only is not currently produced.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[github-actions]

Danger Check Results

Messages

✅	Danger: All checks passed successfully! 🎉

Generated by 🚫 dangerJS against 0ac309c

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud