csr: validate CSRRS/CSRRC writes by register index - #299
Open
carlosqwqqwq wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
csr: validate CSRRS/CSRRC writes by register index
Fixes #293
Commit message
Description
The CSR helper decides whether
CSRRS/CSRRCwrites from the runtime value loaded fromrs1. A nonzerors1register containing zero is therefore mistakenly treated as a read, allowing writes to read-onlytime. Carry the architectural write-intent bit from the decoder into the helper: onlyrs1=x0/zimm=0forms are read-only accesses.Validation
csrrs/csrrcwithrs1 = t0(value zero) against read-onlytimeand accept only the canonicalrs1 = x0read form; the patched build matches both.