fix(grid): make --grid-maxWidth a true maximum instead of a fixed width - #5157
Open
fbasmaison-lucca wants to merge 2 commits into
Open
fix(grid): make --grid-maxWidth a true maximum instead of a fixed width#5157fbasmaison-lucca wants to merge 2 commits into
fbasmaison-lucca wants to merge 2 commits into
Conversation
- Apply the maxWidth custom property through max-inline-size rather than inline-size. - Keep an auto inline-size on mod-form grids: they no longer occupy 50rem when their content is narrower. - Remove the max-inline-size: 100% clamp, unnecessary once no fixed inline-size can overflow. Co-Authored-By: Claude <noreply@anthropic.com>
|
🚀 Storybook preview deployed: https://pub-dc6d99acd6874e2aaff6219dd8a13ae2.r2.dev/PR-5157/index.html |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates grid sizing so --grid-maxWidth acts as a maximum and avoids forcing form grids beyond their container.
Changes:
- Applies
--grid-maxWidththroughmax-inline-size. - Removes the fixed inline size and redundant 100% clamp.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fbasmaison-lucca
force-pushed
the
fix/grid-max-width-as-true-max
branch
from
July 31, 2026 14:39
2873eb7 to
c2da392
Compare
Contributor
|
@fbasmaison-lucca Might you add a tiny |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
--grid-maxWidthnow acts as a true maximum, not a fixed width.Note for reviewers
--grid-max-widthfound outside LF.grid-template-columns: 1fr auto).Context
mod-formsets--grid-maxWidth: var(--components-form-maxWidth, 50rem).inline-size.max-inline-size: 100%clamped it.--grid-maxWidth: noneis invalid forinline-size.autoonly through IACVT.inline-sizedeclaration in the cascade.pr-u-minInlineSize0.Before:
After:
Solution
max-inline-sizeinstead ofinline-size.max-inline-size: 100%clamp.noneis a valid value formax-inline-size.max-inline-size: var(--components-form-maxWidth).Fixes #5188