feat(tooltip, popover2): Share the overlay focus-return suppression - #5272
Draft
fbasmaison-lucca wants to merge 1 commit into
Draft
fbasmaison-lucca wants to merge 1 commit into
fbasmaison-lucca wants to merge 1 commit into
Conversation
fbasmaison-lucca
added
🔨 Technical
fbasmaison-lucca
temporarily deployed
to
staging
August 25, 2026 11:00 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
|
🚀 Storybook preview deployed: https://pub-dc6d99acd6874e2aaff6219dd8a13ae2.r2.dev/PR-5272/index.html |
JeSuisCharlie1
force-pushed
the
feature/tooltip-not-on-overlay-focus-return
branch
from
August 31, 2026 14:01
2619636 to
8b5b8f0
Compare
Base automatically changed from
feature/tooltip-not-on-overlay-focus-return
to
release/22.0
September 1, 2026 07:48
* Extract the detection into `ɵintentionalFocus$`, driven by the CDK `FocusMonitor`. * Add `focusSilently` for an application moving the focus itself. * Require both a `program` origin and a return from a foreign overlay pane. * Restore the popover2 trigger focus through a `program` origin. * Drop the popover2 `#skipNextFocus` flag. * Drop the tooltip `(focus)` and `(focusout)` host listeners. * Cover both components with focus-return story tests. Co-Authored-By: Claude <noreply@anthropic.com>
fbasmaison-lucca
force-pushed
the
feature/tooltip-focus-monitor-variant
branch
from
September 1, 2026 13:42
0723ebf to
6c6ef3d
Compare
fbasmaison-lucca
temporarily deployed
to
staging
September 1, 2026 13:42 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
|
@fbasmaison-lucca We got a regression on popover2 hover+focus : we can't anymore close the dropdown by clicking outside the trigger after giving it the focus: Enregistrement.de.l.ecran.2026-09-22.a.17.10.59.mov |
Contributor
Author
|
Do you want me to look at it? When? |
Contributor
|
@fbasmaison-lucca No emergency, I'm trying to clean open PRs. Depending on front-end feedback, I'll let you know if we want to fix and merge this one. |
Contributor
Author
|
Thanks! I’ll be in standby. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
focusSilentlyfocuses a trigger without revealing its tooltip or its popover.programorigin and a return from a foreign overlay pane.focus()still opens both.Contribution
npm run buildOKnpm run lintOKFunctional review