fix(Tag): IconOnly width adjustments - #5335
Merged
Merged
Conversation
|
🚀 Storybook preview deployed: https://pub-dc6d99acd6874e2aaff6219dd8a13ae2.r2.dev/PR-5335/index.html |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Updates Tag horizontal padding so icon-only and hidden-label variants render at their intended widths.
Changes:
- Adds configurable inline padding.
- Applies reduced padding to icon-only states.
- Expands QA coverage across S, M, and L sizes.
File summaries
| File | Description |
|---|---|
stories/qa/tags/tags.stories.html |
Adds size variants for icon-only and hidden-label tags. |
packages/scss/src/components/tag/vars.scss |
Defines default inline padding. |
packages/scss/src/components/tag/mods.scss |
Adds reduced icon-only padding. |
packages/scss/src/components/tag/index.scss |
Detects relevant icon-only and hidden-label states. |
packages/scss/src/components/tag/component.scss |
Uses the configurable padding variable. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jeremie-lucca
enabled auto-merge (squash)
September 11, 2026 13:34
vvalentin-lucca
approved these changes
Sep 14, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
IconOnlywidth adjustments