feature: implement bot fresh start flag and receive elf solder buff - #880
Merged
Merged
Conversation
sven-n
reviewed
Aug 16, 2026
sven-n
left a comment
Member
There was a problem hiding this comment.
Reviewed the bot buff trips, startup profiles, and stat-weight changes. Two correctness concerns noted inline; the rest looks good.
Generated by Claude Code
sven-n
approved these changes
Aug 16, 2026
sven-n
left a comment
Member
There was a problem hiding this comment.
Both review findings are addressed in e96ec5e: the failed buff-trip path now applies the full NextBuffCheckUtc() backoff, and the effect-scan catch is narrowed to InvalidOperationException with a debug log. CI is green. LGTM.
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #853. Bot improvements: fresh-character startup, friendlier combat targets for low-level bots, Elf Soldier buff trips, and real-player skill parity — bots learn exactly what a player could.
Changes
Start as fresh characters (
StartAsFreshCharacters)BotStartupProfile, chosen at generation (BotStartupProfile.For(...)). Documented indocs/Bots.md; covered byBotStartupProfileTests.Combat level headroom
CombatHandler.IsSafeTargetnow engages monsters up toLevelHeadroom(5) levels above a bot's effective level, so fresh level-1 bots can actually find targets; true safety still comes from the existing damage/defense checks. Two newCombatHandlerTestscases.Elf Soldier buff trips
BotBuffHandlercaches the offers once per game configuration; trips are errands like shopping — they beat hunting/party-follow, andBotPartyHandlerdeclines invites meanwhile. Orchestrated inBotNavigator.TryBuffTripAsync; a no-op on servers without a buff NPC.Skill parity with real players
GetItemGrantedSkillNumbers), so future items are covered automatically; one explicit entry stays for a skill whose granting weapon isn't in the config.