[danieljamesscott]

Let me know what you think. :)

[Moocar]

Could you please add some documentation to the README as well

[Moocar]

You'll also need to add host as a configurable field, and then pass it into the new instance of GelfConverter at https://github.com/Moocar/logback-gelf/blob/master/src/main/java/me/moocar/logbackgelf/GelfLayout.java#L149

[danieljamesscott]

Better? :) Let me know if it needs more work.

[danieljamesscott]

Any update on this? Do I need to make more changes, or is it OK to merge now?

[Moocar]

this should be hostName

[Moocar]

Hey, I've been on holiday all week. Sorry for not getting back sooner. If you can address that last comment I made, then I'll be happy to merge

[danieljamesscott]

No problem. I just wanted to make sure that it didn't get forgotten. I just fixed the readme.

[Moocar]

merged. Thanks for the new feature :)

[danieljamesscott]

Excellent, thanks. Sorry to move straight on to the next request, do you have a timeline for the next release? It would be great to get this in the repositories.

[Moocar]

I'll let it sit for a few days. Are you using this in production? Would be
great if you could verify it. I'll aim for a release next week

On Tue, Dec 17, 2013 at 8:19 PM, Daniel Scott notifications@github.comwrote:

Excellent, thanks. Sorry to move straight on to the next request, do you
have a timeline for the next release? It would be great to get this in the
repositories.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/28#issuecomment-30736266
.

[danieljamesscott]

I have it running on my local system, but I don't have it on any of our prod/uat stacks yet. I need to get an equivalent patch into dropwizard-gelf (https://github.com/gini/dropwizard-gelf) before I can move on... :)

[Moocar]

This is part of release 0.10p2 which should be up on maven central in a couple of hours