Repository navigation
test(discovery): canonicalize tempdir root on darwin - #295
Merged
Merged
Conversation
The workspace-audit lane on tagged commit 088b8bb failed on both darwin jobs: boundaries are reported through filepath.EvalSymlinks while the test compared raw t.TempDir() paths (/var -> /private/var on macOS). Match the established pattern and canonicalize the fixture root. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tag-push platforms lane on 088b8bb (gds-v0.9.42) failed on darwin-amd64 + darwin-arm64: TestDiscoverSkipsIgnoredNestedBoundary compared raw t.TempDir() paths against canonicalized boundary paths. Canonicalize the fixture root via filepath.EvalSymlinks, matching the convention used by the existing tests in this file.
Generated with Devin