Skip to content

Make Hierarchical KV self-sufficient. - #127

Open
bashimao wants to merge 1 commit into
NVIDIA-Merlin:masterfrom
bashimao:nail-down-dependencies
Open

bashimao wants to merge 1 commit into
NVIDIA-Merlin:masterfrom
bashimao:nail-down-dependencies

Conversation

@bashimao

Copy link
Copy Markdown
Collaborator

Changes

  • Make Hierarchical KV self-sufficient.
  • Fix versions of used dependencies. Don't expect the environment to provide them.
  • Move all dependencies to third_party folder.

@bashimao
bashimao force-pushed the nail-down-dependencies branch from b18de4c to a0de3ac Compare May 18, 2023 11:59
@github-actions

Copy link
Copy Markdown

@bashimao
bashimao requested a review from rhdong May 18, 2023 12:07
@bashimao bashimao self-assigned this May 18, 2023
@bashimao bashimao added the enhancement New feature or request label May 18, 2023
@bashimao

Copy link
Copy Markdown
Collaborator Author

Long necessary change and step 1 in order to fix: #126

Comment thread .gitmodules
url = https://github.com/google/googletest.git
ignore = dirty
[submodule "third_party/libcudacxx"]
path = third_party/libcudacxx

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to specify the stable releases or branches. These should be the latest version of them, maybe be helpful:
https://github.com/NVIDIA/thrust/releases/tag/2.1.0
https://github.com/NVIDIA/libcudacxx/releases/tag/2.1.0

@bashimao
bashimao force-pushed the nail-down-dependencies branch from 1be7c3f to 40fb02b Compare May 29, 2023 09:06
@bashimao

Copy link
Copy Markdown
Collaborator Author

Rebased to master.

@rhdong

rhdong commented May 29, 2023

Copy link
Copy Markdown
Member

/blossom-ci

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants