Skip to content

fix(text): allow boilerplate at both top and bottom - #2477

Open
VolodymyrLinuxovich wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
VolodymyrLinuxovich:fix/boilerplate-top-and-bottom
Open

VolodymyrLinuxovich wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
VolodymyrLinuxovich:fix/boilerplate-top-and-bottom

Conversation

@VolodymyrLinuxovich

Copy link
Copy Markdown

Description

Closes #2469

Boilerplate at both the top and bottom of a document was not removed. The helper now accepts a run at the top, a run at the bottom, or both. Added tests.

Checklist

  • I am familiar with the Contributing Guide.
  • New or Existing tests cover these changes.
  • The documentation is up to date with these changes.

Signed-off-by: Volodymyr Borysenko <borysoff21@gmail.com>
@VolodymyrLinuxovich
VolodymyrLinuxovich requested a review from a team as a code owner October 3, 2026 04:37
@VolodymyrLinuxovich
VolodymyrLinuxovich requested review from weijiac0619 and removed request for a team October 3, 2026 04:37
@copy-pr-bot

copy-pr-bot Bot commented Oct 3, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@greptile-apps

greptile-apps Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Changes boilerplate detection logic in text processing.

The PR appears safe to merge; no actionable issue was identified.

Summary

The PR allows the boilerplate modifier to remove separate runs at both the top and bottom of a document, and adds helper and modifier tests for the behavior.

Reviews (1) · Last reviewed commit: "fix(text): allow boilerplate at both top..."

@svcnvidia-nemo-ci svcnvidia-nemo-ci added the waiting-on-maintainers Waiting on maintainers to respond label Oct 5, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-request waiting-on-maintainers Waiting on maintainers to respond

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BoilerPlateStringModifier doesn't strip boilerplate when it's at both the top and bottom

2 participants