Repository navigation
Conversation
Signed-off-by: Rebecca Sliter <571084+rsliter@users.noreply.github.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the
Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Authoring session — opening
Evidence fields corrected after inspecting the persisted authoring record. The original cutoff is preserved; later revision work is excluded. |
|
@coderabbitai full review |
Action performed
|
Code coverage overviewLanguages: TypeScript TypeScript / code-coverage/plugin
View coverage of the 10 most impacted files.
TypeScript / code-coverage/cli
View coverage of the 10 most impacted files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
|
Cycle 1 validation and review disposition Tested commit: All applicable selected regression E2Es passed in run 41538230420, attempt 1. The trusted
The managed-image qualification run also passed, including both Pi candidate builds and all managed runtime activation checks. The authenticated Pi receipt refresh patch is prepared and has not been applied. The candidate remains WIP. The smallest next repair batch is:
All nine Advisor specialists completed successfully. Its blocker gate reports the documentation drift described above; eight specialists recorded no code blocker. The failed CLI shard is the fixture mismatch in item 2. No workflow or test retries were requested. Declined feedback:
Paused after revision cycle 1 at the author's request. No second revision has been committed or pushed. |
Signed-off-by: Rebecca Sliter <571084+rsliter@users.noreply.github.com>
|
🌿 Preview your docs: https://nvidia-preview-pr-14104.docs.buildwithfern.com/nemoclaw |
|
@coderabbitai review |
Action performed
|
|
Cycle 2 validation for
Advisor dispositions:
No retries were required. The PR remains draft pending the cycle 3 repair and its validation. No model-pool or routing-policy change is included. |
Signed-off-by: Rebecca Sliter <571084+rsliter@users.noreply.github.com>
|
@coderabbitai review Cycle 3 is db39a8c. Please review the native-router selection guard and its denial and shared-route regression coverage. |
Action performed
|
Signed-off-by: Rebecca Sliter <571084+rsliter@users.noreply.github.com>
|
@coderabbitai review The approved fourth revision is fcba810. It corrects the remaining registry-recovery shared-route test fixture; production code and all assertions are unchanged. |
Action performed
|
|
Final validation for
All nine Advisor specialists in 41573118423 completed. Their artifacts were hash-verified and bound to this candidate and base. The advisory blocker gate failed on two findings, with these dispositions:
Architecture, customer behavior, migration, recovery, reduction, security, and verification identified no remaining code defect. CodeRabbit completed with no actionable comments; the earlier host-smoke thread is resolved. Advisory docstring expansion is declined under the maintainer's instruction to limit work to regression risk. E2E applicability:
No fifth revision, model-pool change, or routing-policy change is included. All four published commits are Verified. This evidence does not claim that the replacement pool is qualified or that a maintainer has approved merging. |
Signed-off-by: Rebecca Sliter <571084+rsliter@users.noreply.github.com>
|
@coderabbitai review Please review merge commit |
Action not completed
|
Signed-off-by: Rebecca Sliter <571084+rsliter@users.noreply.github.com>
|
@coderabbitai review Please review final commit |
Action performed
|
|
PR Review Advisor finished for commit Request review only when Require no Advisor blockers is green. |
Signed-off-by: Rebecca Sliter <571084+rsliter@users.noreply.github.com>
|
@coderabbitai review |
Action performed
|
Outcome
OpenClaw Model Router onboarding and resume use a restricted, sandbox-attached native provider. Setup no longer requires the built-in
openaicatalog profile or changes the shared inference route for this selection.Reason
Import-only OpenShell gateways have no built-in provider catalog. Model Router needs an owned native endpoint before the replacement pool can ship.
Related issues
Fixes #13560. Prerequisite for #14066; follows #12558.
Changes
nvidia-routerselection.Verification
5348e12f377f121f2ce9f63ff3249f4d2d035b6c, cohortghrun-41654462094-1. AMD64, ARM64, and rootless Podman runtime activation passed.npx vitest run --project cli src/lib/agent/candidate.test.ts: all 13 tests passed, including published receipts for both architectures and refusal of untrusted receipts.d5b0ad64fb3773c104e1eb3ca81d4a47b332b5e2: 291 focused tests passed across nine files, including 12 attachment-recovery regressions. The new regression failed on cycle 6 before repair because resume succeeded without restoring the detached attachment. CLI typechecking, test-project membership, source architecture, and strict staged Pi source parity passed. Independent latest-commit CI, automated reviews, and applicable E2Es are pending.b918a3a14f01d69ce6e49453cb7cf9aee0afb5bc: CI, managed-image qualification, and exact-commit CodeRabbit passed without retries. These results do not qualify the resume repair.fcba810137f1a43f2921e6612aba2af9d945c766: CI, managed-image qualification, and all eight selected E2E executions passed. These results do not qualify the new commit.Review notes
Self-review in NVIDIA/NemoClaw covered the candidate's inference, protected-port, onboarding, configuration-generation, and provider-inventory changes. It traced setup, resume, profile failure, attachment, model changes, credential custody, and owned cleanup. CodeRabbit found no new files to review for the merge commit; its prior reviewed content remains unchanged, and the host-smoke thread is resolved. CodeRabbit completed the receipt-refresh review with no actionable finding. Latest-commit review of the resume repair is pending.
All nine Advisor specialists for
fcba810completed, and their artifacts were hash-verified. The advisory blocker gate failed on public guide drift and a router E2E ownership recommendation. The evidence comment records both dispositions. Public guides follow the permitted post-merge documentation workflow; the owning platform summary is corrected here. The current router E2E explicitly testsinference.local; #14066 owns its native-endpoint oracle and replacement-pool update, including its corresponding ownership metadata. Seven other review areas, including migration and security, found no remaining defect. Cycle 5 Advisor workflows skipped before specialists because CI required the receipt refresh. No maintainer approval or CI waiver is claimed.All nine cycle-6 Advisor specialists succeeded; artifacts were hash- and identity-verified and read in full. Its advisory blocker gate failed on three findings. The valid missing resume attachment was reproduced and repaired in this revision. Public-guide drift retains the permitted post-merge deferral. The old router target still asserts
https://inference.local, so its native-endpoint oracle and corresponding ownership metadata remain #14066 scope. No advisory-gate pass or maintainer approval is claimed.The accepted issue correction places Lightning/SuperVL API checks and complete native-router request E2E in #14066. This PR preserves Model Router and supplies its native provider prerequisite. It does not change the pool or checkpoint policy. Existing legacy shared-route sandboxes retain the explicit recreation boundary owned by #12558.
Signed-off-by: Rebecca Sliter 571084+rsliter@users.noreply.github.com
Summary by CodeRabbit