Repository navigation
test(e2e): deduplicate remote service checks and drop the unrun remote models test - #14146
Merged
Merged
Conversation
…e models test Run each runtime-independent remote_service check once, drop the vLLM Preserve scenario that the SDK's runtime tests own, and delete the remote_models live test and its service_images helpers, which no CI step ran and whose checks remote_service and the SDK's runtime_compile tests own. The Helm recovery tests stay: the SDK's Kubernetes tests run a scripted OpenTofu and cannot reproduce how the Helm provider drops a release binding. Refs #14060, #14061 Signed-off-by: San Dang <sdang@nvidia.com>
Collaborator
Author
Authoring session — opening
|
Contributor
|
v1 documentation preview: https://nvidia-preview-nemoclaw-v1-pr-14146.docs.buildwithfern.com/nemoclaw |
8 tasks
…remote Signed-off-by: San Dang <sdang@nvidia.com> # Conflicts: # crates/nemoclaw-e2e/tests/e2e/main.rs
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failure
Section 4 of the duplicated-checks list on #14060 asked for a review of the
helm_recoveryandremote_serviceintegration tests against the SDK and provider tests. The #14061 list also asked where the remote models live test's checks belong.Part of #14060 and #14061.
Decision
helm_recovery(5) andhelm_recovery::destroy_faults(4)kubernetes_interruption,kubernetes_lost_create_response,kubernetes_read_failures, therecovery_*unit tests) run a scripted OpenTofu. These tests run the bundled Helm provider, which treats a rejected release lookup as an absent release, against the in-memory Kubernetes API. Only they show the SDK restoring that binding.remote_service::remote_vllm_preserve_refuses_image_change…docker_model_updates_preserve_running_containers_unless_recreation_is_explicitowns the Preserve and Recreate decision for vLLM, Ollama, and a remote vLLM. The Ollama scenario keeps a real plan reaching it.remote_servicestepstests/e2e/rust/remote_models.rsandservice_images/(live)NEMOCLAW_TEST_AGENT_PROFILE.remote_serviceowns its observation failure, export, unchanged apply, and retained storage. The SDK'sruntime_compile::remote_service_is_independent_of_the_external_sandbox_gatewayowns where the remote service publishes its port. An agent answering through a remote model needs a real SSH host, which the #14061 checklist already tracks.Rust integration tests: 17 to 16 in these two modules. Net −878 lines.
Validation
remote_serviceandhelm_recoverytests pass against a bundle built fromv1.cargo ci teston darwin_arm64: 1755 tests passed. Clippy fornemoclaw-e2epassed.