Repository navigation
Conversation
Compatibility review (advisory)New or updated breaking changes; see the full report for all findings. 1. api-behavior — No explicit risk acceptance found
Review details
Advisory review; publication gates are unchanged. |
|
Label |
shiju-nv
force-pushed
the
fix/4679-mcp-proposal-fields
branch
from
November 2, 2026 15:53
513efa8 to
e5a3648
Compare
Agent policy proposals currently lose MCP tool selectors before approval. A proposal intended for one `tools/call` tool can therefore become broader than the agent requested. This change preserves supported selectors through parsing, review and runtime validation, and rejects fields that cannot be applied. Signed-off-by: Shiju <shiju@nvidia.com>
shiju-nv
force-pushed
the
fix/4679-mcp-proposal-fields
branch
from
November 3, 2026 11:47
e5a3648 to
ee79082
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Agent policy proposals currently lose MCP tool selectors before approval. A proposal intended for one
tools/calltool can therefore become broader than the agent requested. This change preserves supported selectors through parsing, review and runtime validation, and rejects fields that cannot be applied.Related Issue
Part of #4679, acceptance criteria 1–3. Criterion 4, documenting the prover’s MCP limitations, remains a separate follow-up. Resolve that tracking split before landing; this PR does not close the full issue.
Changes
toolandparams.name, and unloadable rules with actionable validation errors.openshell rule get, escaping control characters so rule content cannot erase or rearrange the approval display. Update the advisor docs and in-sandbox guidance.Release Notes
Target the next minor release. Unsupported proposal fields now return a validation error; earlier releases ignored them. Remove those fields and resubmit, or ask an administrator to add policy features reserved for operator-authored policy files.
Testing
Focused checks pass: eight proposal-parser cases, three runtime validation cases, the shared MCP conversion case, and the existing CLI formatter case extended with control-character input. Scoped Clippy passes for the network, policy and CLI libraries and their tests.
Two isolated controls confirm the regressions: the proposal tests fail against actual main when only the new test cases are applied, and the formatter assertion fails when display escaping is removed. Formatting, SPDX, whitespace and affected docs checks also pass.
test:e2eis applied; no current-head hosted runtime pass is claimed.Checklist