[EmilienM]

Summary

ResolvedWorkloadIdentity derived Deserialize with public fields, so a value decoded from a serialized descriptor skipped the checks new() enforces. Deserialization now goes through a private wire mirror and TryFrom, which delegates to new(): UID/GID 0 and empty or whitespace-only source/digest fail to decode, and supplementary groups are sorted, de-duplicated, and stripped of the primary GID during decode. An unsorted group list in a descriptor used to fail the later match against the admitted identity; it now decodes to the canonical form, so the same logical identities are accepted as before. The wire format for valid values is unchanged.

Related Issue

Closes #5189

Changes

• Added RawResolvedWorkloadIdentity (private, deny_unknown_fields) and #[serde(try_from)] on ResolvedWorkloadIdentity, delegating to new()
• Deserialization tests: UID/GID/supplementary 0, empty and whitespace-only source and digest, group sorting, dedup, and primary-GID removal on decode, round-trip, and rejection of an invalid identity embedded in BoundaryConfirmation
• Follow-ups from the same code read, for types whose validate() covers only part of what they carry:
  • BoundaryConfirmation: session ID, resource claims, and evidence digest are checked by the RPC client, not on decode
  • ProvisioningEvidence: an empty generation is only caught by validate(), and the digest binding cannot be re-verified at decode
  • ExecutableIdentity/BinaryIdentity: absolute-path and ancestor shape are unvalidated on decode

Release Notes

Descriptors carrying an invalid workload identity (UID or GID 0, empty source or resource digest) now fail to deserialize instead of being accepted.

Testing

• Checks appropriate to the affected code and behavior pass (cargo test for openshell-isolation-interface, openshell-sandbox-backend, openshell-supervisor, openshell-driver-{docker,podman,kubernetes,vm}, openshell-sandbox; rust:lint)
• Unit tests added/updated
• E2E tests added/updated (not applicable: no runtime behavior change)

Checklist

• Follows Conventional Commits
• Commits are signed off (DCO)
• Architecture docs updated (not applicable)

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[FrostGod]

/ok to test 2057e57