[PyTorch] NCCL EP eager mode and drop-on-overflow policy#3229
Draft
phu0ngng wants to merge 12 commits into
Draft
[PyTorch] NCCL EP eager mode and drop-on-overflow policy#3229phu0ngng wants to merge 12 commits into
phu0ngng wants to merge 12 commits into
Conversation
Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
…aunchers Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
…r libtransformer_engine.so, not libnccl_ep) Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
…cl-extensions migration Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
…ymm test Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
…recv-token total Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com> Expose the per-step recv-token total as EpBuffer.num_recv_tokens Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PENDING: Need to rebase on top of #3222 and #3187
Description
Add two NCCL EP dispatch options to the PyTorch API:
recv_capacity_per_rank.max_recv_tokens_per_rankare dropped and dispatch continues, instead of trapping.Type of change
Changes
ep.h/ep_backend.cpp: adddrop_on_overflowgroup policy and wirenum_topk+ AUTO recv budget through the group config.pytorch/ep.py:ep_bootstrap(eager=...)toggle captured at bootstrap;EpBufferreads it to size outputs from the per-step recv-token total and exposesnum_recv_tokens. Eager and zero-copy are mutually exclusive, and eager rejects caller-provided output buffers.pytorch/csrc/extensions: plumb the new fields through the dispatch binding.Checklist: