Single group mxfp8 grouped mlp - #3267
Merged
vthumbe1503 merged 17 commits intoJul 29, 2026
Merged
Conversation
Signed-off-by: Siddhartha Raman Sundara Raman <sraman@nvidia.com>
Signed-off-by: Siddhartha Raman Sundara Raman <sraman@nvidia.com>
Signed-off-by: Siddhartha Raman Sundara Raman <sraman@nvidia.com>
Signed-off-by: Siddhartha Raman Sundara Raman <sraman@nvidia.com>
Signed-off-by: Siddhartha Raman Sundara Raman <sraman@nvidia.com>
for more information, see https://pre-commit.ci
Contributor
Greptile SummaryAdds single-group MXFP8 support to the fused grouped-MLP path.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Single-group grouped MLP input] --> B[Quantize as grouped MXFP8 storage]
B --> C[FC1 fused GEMM and activation]
C --> D[Convert one-member grouped activation to MXFP8 tensor view]
D --> E[Dense FC2 GEMM]
E --> F[MLP output]
F --> G[Backward dactivation]
G --> H[Dense single-group dgrad]
G --> I[Dense single-group wgrad]
Reviews (9): Last reviewed commit: "Skip runtime-offset test with older cuDN..." | Re-trigger Greptile |
timmoon10
reviewed
Jul 27, 2026
timmoon10
left a comment
Member
There was a problem hiding this comment.
Mostly fine as a hacky expedient. Remember that the single-group approach is a dead end and we should not put much more effort into it. The right approach is to implement a dense MLP fused op.
Signed-off-by: Siddhartha Raman Sundara Raman <sraman@nvidia.com>
Co-authored-by: Tim Moon <4406448+timmoon10@users.noreply.github.com> Signed-off-by: Siddhartha Raman Sundara Raman <sraman@nvidia.com>
Signed-off-by: Siddhartha Raman Sundara Raman <sraman@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Siddhartha Raman Sundara Raman <sraman@nvidia.com>
Signed-off-by: Siddhartha Raman Sundara Raman <sraman@nvidia.com>
for more information, see https://pre-commit.ci
vthumbe1503
previously approved these changes
Jul 28, 2026
Collaborator
|
/te-ci pytorch |
Signed-off-by: Siddhartha Raman Sundara Raman <sraman@nvidia.com>
Contributor
Author
|
/te-ci pytorch |
1 similar comment
Collaborator
|
/te-ci pytorch |
vthumbe1503
approved these changes
Jul 29, 2026
vthumbe1503
approved these changes
Jul 29, 2026
vthumbe1503
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Although I agree with Tim, grouped_mlp has now become grouped_mlp+dense_mlp. We probably should consider migrating it to a seperate fused op soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a brief summary of the changes, relevant motivation and context.
Fixes # (issue)
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: