Repository navigation
feat(pages): saved pictures on hosted pages, and web research before writing one - #68
Merged
Merged
Conversation
…itinerary stop An image block takes attachment_ids (alongside url); itinerary and checklist blocks take one id per item. Pictures are served through /p/<slug>/pictures/<id>, which applies the page's own gate, serves only a picture a block names, and refuses the owner's own pictures on a shared page and any picture from a chat other than the page's. The turn context lists the message's picture ids as `pictures`. Co-authored-by: Cursor <cursoragent@cursor.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-authored-by: Cursor <cursoragent@cursor.com>
NatanTechofNY
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 82402c9561
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ix research copy flow Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The agent can now put a ticket, receipt or photo someone texted onto a hosted page.
imageblocks takeattachment_ids(and stillurl);itinerary/checklistblocks take one id per item (""for none), so a ticket sits under its stop. The agent learns ids fromturnContext.pictures(this message) or a memory's attachments (get_memory).Privacy rules (chosen by the owner)
How they are served
GET /p/:slug/pictures/:attachmentId: same open/gate as the page (owner page needs the session; revoked/expired is 404), serves only a picture one of the page's blocks names,default-src 'none'; sandbox,nosniff,private, no-cache. Page CSP gainsimg-src 'self'./api/attachmentsis not exposed. A deleted picture is left off the page.Also
Tool schema (
client-tools.json, bothcreate_pageandupdate_page), system prompt, README and docs updated. Needs "Sync Agent config" after deploy for the agent to learn the new field.Tests
New test covers owner/shared/group/anonymous access, unnamed picture, wrong-chat and unknown ids, bad block types and counts, deleted picture, revoke; turn-context assertion added to the receipt test.
Made with Cursor
Web research (added)
The prompt now tells the agent to look public facts up with
web_search/read_web_pageas freely as it takes before writing them on a page (hours, addresses, travel times, prices, show times, weather), to keep queries to public words, to link the source of facts that matter, and to leave off or mark anything it could not confirm. No server change: the web tools are already allowed on these turns. Limits that still apply: 16 tool rounds / 4 min per turn, the daily lookup cap (BRIGHTDATA_DAILY_LIMIT, a quarter for groups), andcreate_pagewiththread_idfrom the owner's chat is still refused on a turn that used the web (the prompt says to make it for the owner first, then file a copy under the group next ask).