Skip to content

Bugfix/cstackex 327-Concurrent iSCSI VM deployment fails intermittently: post-clone LUN resize returns 404 #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sp16743 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Bugfix/cstackex 327-Concurrent iSCSI VM deployment fails intermittently: post-clone LUN resize returns 404 #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6110c07
Bug Fix:CSTACKEX-327:-Concurrent iSCSI VM deployment fails intermitte…
sp16743 Oct 9, 2026
54dc776
Remove the extra LUN resize comment.
sp16743 Oct 9, 2026
62c8ec7
changes
sp16743 Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 33 additions & 15 deletions .../volume/ontap/src/main/java/org/apache/cloudstack/storage/service/UnifiedSANStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,22 +306,40 @@ public void resizeCloudStackVolume(CloudStackVolume cloudstackVolume, long sizeI
if (sizeInBytes <= 0) {
throw new CloudRuntimeException("Failed to resize Lun, invalid size " + sizeInBytes);
}
String authHeader = OntapStorageUtils.generateAuthHeader(storage.getUsername(), storage.getPassword());
LunSpace lunSpace = new LunSpace();
lunSpace.setSize(sizeInBytes);
Lun patch = new Lun();
patch.setSpace(lunSpace);

int maxRetries = OntapStorageConstants.ONTAP_LUN_RESIZE_MAX_RETRIES;
int pollIntervalMs = OntapStorageConstants.ONTAP_LUN_RESIZE_RETRY_INTERVAL_MS;
String lunUuid = cloudstackVolume.getLun().getUuid();
logger.trace("resizeCloudStackVolume: Resizing Lun {} to {} bytes", lunUuid, sizeInBytes);
try {
String authHeader = OntapStorageUtils.generateAuthHeader(storage.getUsername(), storage.getPassword());
LunSpace lunSpace = new LunSpace();
lunSpace.setSize(sizeInBytes);
Lun patch = new Lun();
patch.setSpace(lunSpace);
JobResponse response = sanFeignClient.updateLun(authHeader, lunUuid, patch);
pollJobIfPresent(response, "resize Lun [" + lunUuid + "]");
logger.debug("resizeCloudStackVolume: Lun {} resized to {} bytes", lunUuid, sizeInBytes);
} catch (FeignException e) {
throw new CloudRuntimeException("Failed to resize Lun: " + e.getMessage(), e);
} catch (Exception e) {
logger.error("Exception occurred while resizing LUN: {}, Exception: {}", lunUuid, e.getMessage());
throw new CloudRuntimeException("Failed to resize Lun: " + e.getMessage());
for (int attempt = 1; ; attempt++) {
logger.trace("resizeCloudStackVolume: Resizing Lun {} to {} bytes", lunUuid, sizeInBytes);
try {
JobResponse response = sanFeignClient.updateLun(authHeader, lunUuid, patch);
pollJobIfPresent(response, "resize Lun [" + lunUuid + "]");
logger.debug("resizeCloudStackVolume: Lun {} resized to {} bytes", lunUuid, sizeInBytes);
return;
} catch (FeignException e) {
if (e.status() != 404 || attempt >= maxRetries) {
logger.error("FeignException occurred while resizing LUN: {}, Status: {}, Exception: {}",
lunUuid, e.status(), e.getMessage());
throw new CloudRuntimeException("Failed to resize Lun: " + e.getMessage(), e);
}
logger.debug("resizeCloudStackVolume: PATCH for Lun {} returned 404, retry {}/{}",
lunUuid, attempt, maxRetries);
} catch (Exception e) {
logger.error("Exception occurred while resizing LUN: {}, Exception: {}", lunUuid, e.getMessage());
throw new CloudRuntimeException("Failed to resize Lun: " + e.getMessage(), e);
}
try {
Thread.sleep(pollIntervalMs);
} catch (InterruptedException ie) {
Thread.currentThread().interrupt();
throw new CloudRuntimeException("Interrupted while waiting for Lun to accept resize", ie);
}
}
}

Expand Down
3 changes: 3 additions & 0 deletions ...volume/ontap/src/main/java/org/apache/cloudstack/storage/utils/OntapStorageConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,9 @@ public class OntapStorageConstants {
public static final int ONTAP_CG_JOB_POLL_INTERVAL_MS = 2000;
public static final int ONTAP_CG_SNAPSHOT_RESOLVE_MAX_RETRIES = 30;
public static final int ONTAP_CG_SNAPSHOT_RESOLVE_POLL_INTERVAL_MS = 1000;
/** Retry settings for a newly cloned LUN that is not yet visible to the resize API. */
public static final int ONTAP_LUN_RESIZE_MAX_RETRIES = 30;
public static final int ONTAP_LUN_RESIZE_RETRY_INTERVAL_MS = 1000;
public static final int ONTAP_SFSR_JOB_MAX_RETRIES = 60;
public static final int ONTAP_SFSR_JOB_POLL_INTERVAL_MS = 2000;
public static final int ONTAP_SNAPSHOT_DELETE_JOB_MAX_RETRIES = 30;
Expand Down
Loading