Repository navigation
feat: add FlexGroup create support to create_volume - #223
Merged
Merged
Conversation
dbtinsley
requested review from
Hardikl,
cgrinds and
rahulguptajss
as code owners
September 11, 2026 15:54
Expose style, multi-aggregate placement, and related FlexGroup fields on create_volume for Unified NAS, while keeping AFX FlexVol create from NetApp#198 and failing closed on classic ASA and ASA r2.
Avoid contextcheck by not calling getHTTPClient from Remote, and use builtin new() in volume tests instead of pointer helpers. Co-authored-by: Cursor <cursoragent@cursor.com>
dbtinsley
force-pushed
the
feat/flexgroup-create-volume
branch
from
September 16, 2026 04:36
bc3cefe to
0aaf774
Compare
Classic ASA is Model=CDOT with san_optimized set, so CreateVolume needs that flag from the existing GetClusterInfo cache rather than a second client.Remote call. Also reject empty aggregate_names entries. Co-authored-by: Cursor <cursoragent@cursor.com>
Hardikl
reviewed
Sep 22, 2026
Hardikl
approved these changes
Sep 22, 2026
cgrinds
approved these changes
Sep 28, 2026
cgrinds
left a comment
cgrinds
left a comment
Collaborator
There was a problem hiding this comment.
@rahulguptajss comments will be addressed in the same PR that adds this feature to ONTAP-MCP's CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create_volumewith FlexGroup fields (style,aggregate_names,constituents_per_aggregate,optimize_aggr_list,granular_data) so agents can create a Unified NAS FlexGroup without dropping to REST.create_volume(use storage units). FlexVol on CDOT/classic ASA is unchanged when the new fields are unset.Test plan
server/volume_test.go: CDOT FlexVol JSON body unchanged; FlexGroup with two aggregates andconstituents_per_aggregate; reject both aggregate fields; reject FlexGroup withoutaggregate_names; rejectflexgroup_constituent; reject FlexGroup-only fields on FlexVol;optimize_aggr_listomit/false/true;granular_datadisabled/basic/advanced/invalid; classic ASA FlexGroup refuse and FlexVol allow; AFX FlexGroup refuse; AFX FlexVol without aggregate.TestNewCreateVolumecases still pass (CDOT/AFX/ASA r2).GOTOOLCHAIN=go1.27.1 go test ./...