Skip to content

highs: init at 1.6.0 - #273289

Closed
david-r-cox wants to merge 2 commits into
NixOS:masterfrom
integrated-reasoning:highs
Closed

highs: init at 1.6.0#273289
david-r-cox wants to merge 2 commits into
NixOS:masterfrom
integrated-reasoning:highs

Conversation

@david-r-cox

@david-r-cox david-r-cox commented Dec 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@david-r-cox
david-r-cox marked this pull request as ready for review December 10, 2023 08:04
@quantenzitrone

quantenzitrone commented Dec 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

You need to add yourself to maintainers/maintainer-list.nix (in a separate commit).

@david-r-cox

david-r-cox commented Dec 10, 2023

Copy link
Copy Markdown
Member Author

You need to add yourself to maintainers/maintainer-list.nix (in a separate commit).

Thanks @quantenzitrone -- I updated maintainer-list.nix in #273252 and will wait for that to merge before running nixpkgs-review.

eclairevoyant
eclairevoyant suggested changes Dec 11, 2023
View reviewed changes

@eclairevoyant eclairevoyant left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as the maintainer commit, can you rebase this branch to come off 6290195 where you added yourself to maintainers? That way you're not really duplicating work, but ofborg can eval it.

Comment thread pkgs/by-name/hi/highs/package.nix Outdated
Comment thread pkgs/by-name/hi/highs/package.nix Outdated
Comment thread pkgs/by-name/hi/highs/package.nix Outdated
Comment thread pkgs/by-name/hi/highs/package.nix Outdated
@david-r-cox
david-r-cox marked this pull request as draft December 12, 2023 05:06
@david-r-cox
david-r-cox marked this pull request as ready for review December 12, 2023 05:07
@david-r-cox

david-r-cox commented Dec 12, 2023

Copy link
Copy Markdown
Member Author

Result of nixpkgs-review pr 273289 run on x86_64-linux 1

1 package built:
  • highs

eclairevoyant
eclairevoyant suggested changes Dec 12, 2023
View reviewed changes

@eclairevoyant eclairevoyant left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more bit of feedback, but otherwise tested out on my end, seems good

Comment thread pkgs/by-name/hi/highs/package.nix Outdated
@eclairevoyant eclairevoyant added the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 12, 2023
@ofborg ofborg Bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 12, 2023
@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Dec 12, 2023
@david-r-cox

david-r-cox commented Dec 14, 2023

Copy link
Copy Markdown
Member Author

@eclairevoyant is there anything else that I should be doing on this PR? This (along with #273296, #273295, and #273252) is my first time contributing to nixpkgs. Thanks again for the review.

@eclairevoyant

eclairevoyant commented Dec 14, 2023

Copy link
Copy Markdown
Contributor

I approved but I don't have access to merge

eclairevoyant
eclairevoyant reviewed Feb 27, 2024
View reviewed changes
Comment thread pkgs/by-name/hi/highs/package.nix
homepage = "https://www.highs.dev";
license = with licenses; [ mit ];
maintainers = with maintainers; [ david-r-cox ];
mainProgram = "highs";

@eclairevoyant eclairevoyant Feb 27, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the CI again - do you know why the tests are failing on darwin?

@wegank wegank removed the 12.approvals: 2 This PR was reviewed and approved by two persons. label Mar 8, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 8, 2024
@KiaraGrouwstra

KiaraGrouwstra commented Mar 16, 2024

Copy link
Copy Markdown
Contributor

looks like #295386 already got merged

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@eclairevoyant eclairevoyant eclairevoyant approved these changes
@quantenzitrone quantenzitrone quantenzitrone approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@david-r-cox @quantenzitrone @eclairevoyant @KiaraGrouwstra @delroth @wolfgangwalther @wegank