Conversation
|
Just my personal view (thinkpad user here, not a hardware engineer): Im not sure if the upstream analysis, that a delayed fan response leads to a system crash, is reproducible with almost any current hardware. AMD and Intel have both measures to suppress this by slow down at hardware rate level - even a rt scheduler process or physical fan / pwm can not respond in any way. (categories apart!) But there is a good point in there!
could avoid pointless slowdown of a system under pressure. Currently we have a even a systemd 30s blackout after an internal error or OOM kills the process:
A 30second downtime is a category that could indeed lead to some problems. Maybe some linux kernel specialist can jump in here? At least, Im very curious how upstream expertise will proceed 👍 |
|
@paepckehh I have incorporated your suggestions with comments. According to the manpages, I believe you meant |
bbe6ce8 to
a9e351e
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2423 |
I consider this process a critical part of the system software stack and as such want it to be responsive to sensor readings.
This reflects vmatare/thinkfan#198, which has not been merged.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.