Skip to content
This repository was archived by the owner on Aug 12, 2026. It is now read-only.

fix: the inconsistency between the UI size and the screen size in the first frame - #93

Open
Tobiichi-Origuchi wants to merge 1 commit into
NotAShelf:masterfrom
Tobiichi-Origuchi:fix-first-frame
Open

fix: the inconsistency between the UI size and the screen size in the first frame#93
Tobiichi-Origuchi wants to merge 1 commit into
NotAShelf:masterfrom
Tobiichi-Origuchi:fix-first-frame

Conversation

@Tobiichi-Origuchi

Copy link
Copy Markdown

After Plymouth finishes, when Tuigreet renders the first frame, the size of that frame (25,80 for my device) may not match the screen size (50,160 for my device), causing the UI to appear crammed into the top-left corner. It isn’t until the second frame (0.5 seconds later) that the correct size is obtained, and the UI is centered and displayed normally.

After Plymouth finishes, KMS will send a SIGWINCH. Having the UI redraw when this signal is received will resolve the issue.

@Tobiichi-Origuchi

Copy link
Copy Markdown
Author

I'm not sure if this issue can be reproduced on other devices, but triggering a redraw after a TermEvent::Resize isn't any expensive operation in itself, while it ensures the rendering is correct.

@NotAShelf

Copy link
Copy Markdown
Owner

Bit of a weird issue, but the solution LGTM. Since I can't quite reproduce and test the fix, I'll merge this as is. Diff LGTM.

One thing I'll ask of you is to fix your commit message; this repository uses scoped commits and I'd like to avoid squashing to change the message.

@Tobiichi-Origuchi Tobiichi-Origuchi changed the title Fixed the inconsistency between the UI size and the screen size in the first frame fix: the inconsistency between the UI size and the screen size in the first frame Jul 12, 2026
@soupy-boy

Copy link
Copy Markdown
Contributor

@NotAShelf it looks like the commit message has been fixed so you should be good to merge. Also, maybe we should make a Contributing.md explaining what we want commits in prs to look like?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants