This repository was archived by the owner on Aug 12, 2026. It is now read-only.
fix: the inconsistency between the UI size and the screen size in the first frame - #93
Open
Tobiichi-Origuchi wants to merge 1 commit into
Open
fix: the inconsistency between the UI size and the screen size in the first frame#93Tobiichi-Origuchi wants to merge 1 commit into
Tobiichi-Origuchi wants to merge 1 commit into
Conversation
Author
|
I'm not sure if this issue can be reproduced on other devices, but triggering a redraw after a |
Owner
|
Bit of a weird issue, but the solution LGTM. Since I can't quite reproduce and test the fix, I'll merge this as is. Diff LGTM. One thing I'll ask of you is to fix your commit message; this repository uses scoped commits and I'd like to avoid squashing to change the message. |
Tobiichi-Origuchi
force-pushed
the
fix-first-frame
branch
from
July 12, 2026 10:08
9fabf6e to
19d6f82
Compare
Contributor
|
@NotAShelf it looks like the commit message has been fixed so you should be good to merge. Also, maybe we should make a Contributing.md explaining what we want commits in prs to look like? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After Plymouth finishes, when Tuigreet renders the first frame, the size of that frame (25,80 for my device) may not match the screen size (50,160 for my device), causing the UI to appear crammed into the top-left corner. It isn’t until the second frame (0.5 seconds later) that the correct size is obtained, and the UI is centered and displayed normally.
After Plymouth finishes, KMS will send a
SIGWINCH. Having the UI redraw when this signal is received will resolve the issue.