Repository navigation
Conversation
PrescribedAtmosphere defaulted to 512 m while the Breeze and SpeedyWeather interfaces used 600 m. Define `default_boundary_layer_height = 600` once in EarthSystemModels (the COARE mixed-layer depth) and use it everywhere. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PrescribedAtmosphere accepts a 2D FieldTimeSeries for `boundary_layer_height`, interpolated onto the exchange grid alongside the tracers; a number becomes a ConstantField. The regridded exchanger state takes precedence over the atmosphere's `boundary_layer_height` in the flux kernels' atmosphere data. ERA5PrescribedAtmosphere loads ERA5's `boundary_layer_height` (blh) unless a number is passed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The function returns the source fields before interpolation, so a past participle misread as already regridded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PrescribedAtmospherehad a hard-codedboundary_layer_height = 512m, a scalar that sets the mixed-layer depth in the convective gustiness, Uᴳ = β (Jᵇ h)^(1/3). Breeze and SpeedyWeather fall back to 600 m for the same quantity. This PR:EarthSystemModels.default_boundary_layer_height = 600m (the COARE mixed-layer depth) and uses it inPrescribedAtmosphere, Breeze, and SpeedyWeather. Under convective conditions this raises the default-configuration gustiness by (600/512)^(1/3) ≈ 5.4 %, which affects the iterative solution of similarity theory fluxes; stable conditions are unaffected.PrescribedAtmospheretake a 2DFieldTimeSeriesforboundary_layer_height. It is interpolated in space and time onto the exchange grid through the same path as thetracers; a number becomes aConstantField. The flux kernels read the regridded exchanger state ahead ofboundary_layer_height(atmosphere).ERA5PrescribedAtmosphereload ERA5'sboundary_layer_height(blh) by default; passing a number keeps a constant.The ERA5 variable mapping overlaps with #709, which adds the same
:boundary_layer_heightentry; whichever merges second drops its copy.Tests:
test_prescribed_atmosphere.jladds a linearboundary_layer_heighttime series on its own grid to the existing tracer-regridding test and checks the exchanger state against it exactly.🤖 Generated with Claude Code